Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Braintree: Failed with test_defined_refs_exist_in_schema in SAT Discover tests #8767

Closed
yevhenii-ldv opened this issue Dec 14, 2021 · 0 comments · Fixed by #9042
Closed
Assignees

Comments

@yevhenii-ldv
Copy link
Contributor

Environment

  • Braintree connector: version 0.1.1
  • Severity: Medium
  • Step where error happened: SAT tests

Current Behavior

Failed.

Expected Behavior

Successfully pass.

Logs

You can find it here

LOG

test_core.py ..........F.                                                [ 80%]
test_full_refresh.py .                                                   [ 86%]
test_incremental.py ..                                                   [100%]

=================================== FAILURES ===================================
___________ TestDiscovery.test_defined_refs_exist_in_schema[inputs0] ___________

self = <source_acceptance_test.tests.test_core.TestDiscovery object at 0x7f4df37b7290>
connector_config = SecretDict(******)
discovered_catalog = ***'customer_stream': AirbyteStream(name='customer_stream', json_schema=***'type': 'object', 'properties': ***'addresses': ***...h'>*** source_defined_cursor=None, default_cursor_field=None, source_defined_primary_key=[['id']*** namespace=None), ...***

    def test_defined_refs_exist_in_schema(self, connector_config, discovered_catalog):
        """Checking for the presence of unresolved `$ref`s values within each json schema"""
        schemas_errors = []
        for stream_name, stream in discovered_catalog.items():
            check_result = find_key_inside_schema(schema_item=stream.json_schema, key="$ref")
            if check_result is not None:
                schemas_errors.append(***stream_name: check_result***)
    
>       assert not schemas_errors, f"Found unresolved `$refs` values for selected streams: ***tuple(schemas_errors)***."
E       AssertionError: Found unresolved `$refs` values for selected streams: (***'customer_stream': ***'$ref': '#/definitions/Address'*** ***'dispute_stream': ***'$ref': '#/definitions/Evidence'*** ***'transaction_stream': ***'$ref': '#/definitions/AndroidPayCard'*** ***'merchant_account_stream': ***'$ref': '#/definitions/BussinessDetails'*** ***'plan_stream': ***'$ref': '#/definitions/AddOn'*** ***'subscription_stream': ***'$ref': '#/definitions/AddOn'***).
E       assert not [***'customer_stream': ***'$ref': '#/definitions/Address'*** ***'dispute_stream': ***'$ref': '#/definitions/Evidence'*** ***'tra...Details'*** ***'plan_stream': ***'$ref': '#/definitions/AddOn'*** ***'subscription_stream': ***'$ref': '#/definitions/AddOn'***]

/usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_core.py:162: AssertionError
=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
======================== 1 failed, 14 passed in 24.91s =========================

Are you willing to submit a PR?

Yes

@yevhenii-ldv yevhenii-ldv added type/bug Something isn't working needs-triage labels Dec 14, 2021
@sherifnada sherifnada added area/connectors Connector related issues and removed needs-triage labels Dec 15, 2021
@sherifnada sherifnada moved this to Prioritized for Scoping in GL Roadmap Dec 17, 2021
@oustynova oustynova moved this from Prioritized for Scoping to Ready for implementation in GL Roadmap Dec 17, 2021
@annalvova05 annalvova05 self-assigned this Dec 20, 2021
@oustynova oustynova moved this from Ready for implementation to Implementation in progress in GL Roadmap Dec 21, 2021
@annalvova05 annalvova05 linked a pull request Dec 22, 2021 that will close this issue
16 tasks
@annalvova05 annalvova05 moved this from Implementation in progress to Internal Review in GL Roadmap Dec 22, 2021
@annalvova05 annalvova05 moved this from Internal Review to Done in GL Roadmap Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants