Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Braintree: resolve '$ref' in schema and spec #9042

Merged
merged 6 commits into from
Dec 22, 2021

Conversation

annalvova05
Copy link
Contributor

@annalvova05 annalvova05 commented Dec 22, 2021

What

#8767 - Integration tests are passed.

How

Resolve refs in schema and spec.

Recommended reading order

  1. spec.py
  2. common.py

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@annalvova05 annalvova05 self-assigned this Dec 22, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 22, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 22, 2021
@annalvova05 annalvova05 temporarily deployed to more-secrets December 22, 2021 14:05 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Dec 22, 2021

/test connector=connectors/source-braintree

🕑 connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1611634022
✅ connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1611634022
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                           Stmts   Miss  Cover
	 ------------------------------------------------------------------
	 source_braintree/__init__.py                       2      0   100%
	 source_braintree/schemas/__init__.py               8      0   100%
	 source_braintree/schemas/cards.py                 86      0   100%
	 source_braintree/schemas/common.py                48      0   100%
	 source_braintree/schemas/customer.py              28      0   100%
	 source_braintree/schemas/discount.py              13      0   100%
	 source_braintree/schemas/dispute.py               37      0   100%
	 source_braintree/schemas/merchant_account.py      29      0   100%
	 source_braintree/schemas/plan.py                  21      0   100%
	 source_braintree/schemas/subscription.py          35      0   100%
	 source_braintree/schemas/transaction.py           99      0   100%
	 source_braintree/source.py                        18      0   100%
	 source_braintree/spec.py                          32      0   100%
	 source_braintree/streams.py                      100      0   100%
	 ------------------------------------------------------------------
	 TOTAL                                            556      0   100%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 14:08 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add title and order properties for all spec options

docs/integrations/sources/braintree.md Outdated Show resolved Hide resolved
@annalvova05 annalvova05 temporarily deployed to more-secrets December 22, 2021 16:16 Inactive
@antixar antixar self-requested a review December 22, 2021 16:18
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please publish this
Spec titles will be added this PR

@annalvova05
Copy link
Contributor Author

annalvova05 commented Dec 22, 2021

/publish connector=connectors/source-braintree

🕑 connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1612144087
✅ connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1612144087

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 16:23 Inactive
@annalvova05 annalvova05 merged commit c142dc1 into master Dec 22, 2021
@annalvova05 annalvova05 deleted the alvova/8767-braintree-resolve-refs branch December 22, 2021 16:32
@annalvova05 annalvova05 temporarily deployed to more-secrets December 22, 2021 16:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/braintree connectors/sources-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Braintree: Failed with test_defined_refs_exist_in_schema in SAT Discover tests
4 participants