Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in source-connectors specifications: amplitude, apify-dataset, appstore-singer, aws-cloudtrail, azure-table, bigcommerce, bigquery, braintree, cart, chargebee #8434

Merged
merged 16 commits into from
Dec 23, 2021

Conversation

karinakuz
Copy link
Contributor

@karinakuz karinakuz commented Dec 2, 2021

What

Update fields in source-connectors specifications:

source-amplitude
source-apify-dataset
source-appstore-singer
source-aws-cloudtrail
source-azure-table
source-bigcommerce
source-bigquery
source-braintree
source-cart
source-chargebee

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yevhenii-ldv
❌ Karina


Karina seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@karinakuz karinakuz temporarily deployed to more-secrets December 2, 2021 14:49 Inactive
@yevhenii-ldv
Copy link
Contributor

yevhenii-ldv commented Dec 23, 2021

/publish connector=connectors/source-cart

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1615529013
✅ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1615529013

@yevhenii-ldv
Copy link
Contributor

yevhenii-ldv commented Dec 23, 2021

/publish connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1615529135
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1615529135

@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:24 Inactive
@yevhenii-ldv
Copy link
Contributor

yevhenii-ldv commented Dec 23, 2021

/publish connector=connectors/source-braintree

🕑 connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1615553609
✅ connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1615553609

@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 12:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment