Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nullable connection schedule #10107

Merged
merged 4 commits into from
Mar 1, 2022
Merged

fix: nullable connection schedule #10107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d99cb3
fix: nullable connection schedule
azhard Feb 4, 2022
015509e
chore: re-add accidentally removed schedule from ConnectionRead
azhard Feb 4, 2022
963cfcc
update doc
alafanechere Feb 24, 2022
c9d7c09
Merge branch 'master' into fix/nullable-connection-schedule
alafanechere Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions airbyte-api/src/main/openapi/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2797,9 +2797,7 @@ components:
syncCatalog:
$ref: "#/components/schemas/AirbyteCatalog"
schedule:
Copy link
Contributor

@jrhizor jrhizor Feb 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schedule should still exist as part of the ConnectionRead even if the nullable is moved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops, accidentally removed it entirely. Will update

nullable: true
allOf:
- $ref: "#/components/schemas/ConnectionSchedule"
$ref: "#/components/schemas/ConnectionSchedule"
status:
$ref: "#/components/schemas/ConnectionStatus"
resourceRequirements:
Expand Down Expand Up @@ -2881,6 +2879,7 @@ components:
ConnectionSchedule:
description: if null, then no schedule is set.
type: object
nullable: true
required:
- units
- timeUnit
Expand Down
45 changes: 36 additions & 9 deletions docs/reference/api/generated-api-html/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down Expand Up @@ -557,7 +560,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down Expand Up @@ -720,7 +726,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down Expand Up @@ -768,7 +777,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down Expand Up @@ -874,7 +886,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down Expand Up @@ -922,7 +937,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down Expand Up @@ -1190,7 +1208,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down Expand Up @@ -1238,7 +1259,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down Expand Up @@ -1502,7 +1526,10 @@ <h3 class="field-label">Example data</h3>
"memory_limit" : "memory_limit",
"cpu_request" : "cpu_request"
},
"schedule" : "",
"schedule" : {
"units" : 0,
"timeUnit" : "minutes"
},
"prefix" : "prefix",
"name" : "name",
"syncCatalog" : {
Expand Down