Extract test helper function to truncate all tables #10286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple persistence test truncates tables when they need to reset the state of the DB. All subclasses of `BaseDatabaseConfigPersistenceTest` now relies on `truncateAllTables` to do so.
|
|
tuliren
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple persistence test truncates tables when they need to reset the
state of the DB. All subclasses of
BaseDatabaseConfigPersistenceTestnow relies on
truncateAllTablesto do so.What
This removes sum duplicate code in the test classes of the persistence layer
How
A new function is created in the base class that all the test classes inherit.