Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Prevented double slashes in S3 destination path #10318

Merged
merged 4 commits into from
Feb 15, 2022
Merged

🐛 Prevented double slashes in S3 destination path #10318

merged 4 commits into from
Feb 15, 2022

Conversation

andriikorotkov
Copy link
Contributor

@andriikorotkov andriikorotkov commented Feb 14, 2022 •
edited
Loading

What

Prevented double slashes in S3 destination path

Recommended reading order

  1. S3OutputPathHelper.java

🚨 User Impact 🚨

No impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 14, 2022
@andriikorotkov andriikorotkov linked an issue Feb 14, 2022 that may be closed by this pull request
Prevent double slashes in S3 destination path #4406
Closed
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 14, 2022 15:48 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 14, 2022 15:48 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 14, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1842021704
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1842021704
No Python unittests run

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 14, 2022 15:53 Inactive
@andriikorotkov andriikorotkov marked this pull request as ready for review February 14, 2022 16:23
alexandr-shegeda
alexandr-shegeda approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
e042c77 
…4406-double-slashes-in-S3

� Conflicts:
�	airbyte-config/init/src/main/resources/config/STANDARD_DESTINATION_DEFINITION/4816b78f-1489-44c1-9060-4b19d5fa9362.json
�	docs/integrations/destinations/s3.md
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 15, 2022 08:13 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 15, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1845779291
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1845779291
No Python unittests run

@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 15, 2022 08:21 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 15, 2022 08:22 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 15, 2022 08:23 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 15, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1845932781
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1845932781

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 15, 2022 08:59 Inactive
@andriikorotkov andriikorotkov merged commit 838ce14 into master Feb 15, 2022
@andriikorotkov andriikorotkov deleted the akorotkov/4406-double-slashes-in-S3 branch February 15, 2022 09:39
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@VitaliiMaltsev VitaliiMaltsev VitaliiMaltsev approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent double slashes in S3 destination path
5 participants
@andriikorotkov @edgao @alexandr-shegeda @VitaliiMaltsev @octavia-squidington-iii