-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rest-hooks for specifications load #10764
Conversation
@@ -21,7 +21,6 @@ | |||
"@fortawesome/free-solid-svg-icons": "^5.15.4", | |||
"@fortawesome/react-fontawesome": "^0.1.16", | |||
"@fullstory/browser": "^1.4.9", | |||
"@rest-hooks/legacy": "^2.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Before we move this onto react-query I think we should solve the problem with relaoding data when focus changed, to prevent reloading the source definitions on focus changes. Testing this also seems to break the app for me locally. Whenever you go to the "New Source" or "New destination" page, it will immediately try to load the source/destination specification, before the user selected an actual source/destination from the dropdown. It will then have Peek.2022-03-09.09-58.mp4 |
Fixed the problem with unnecessary call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested locally to setup connection, seems not to break anything.
What
Partially removes rest-hooks resources #10400