Remove rest-hooks for specifications load #10764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
timroes
reviewed
Mar 1, 2022
| @@ -21,7 +21,6 @@ | |||
| "@fortawesome/free-solid-svg-icons": "^5.15.4", | |||
| "@fortawesome/react-fontawesome": "^0.1.16", | |||
| "@fullstory/browser": "^1.4.9", | |||
| "@rest-hooks/legacy": "^2.0.5", | |||
|
Before we move this onto react-query I think we should solve the problem with relaoding data when focus changed, to prevent reloading the source definitions on focus changes. Testing this also seems to break the app for me locally. Whenever you go to the "New Source" or "New destination" page, it will immediately try to load the source/destination specification, before the user selected an actual source/destination from the dropdown. It will then have Peek.2022-03-09.09-58.mp4 |
|
Fixed the problem with unnecessary call. |
timroes
approved these changes
Mar 22, 2022
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Partially removes rest-hooks resources #10400