🎉 Source Snowflake: support oauth #10953

yurii-bidiuk · 2022-03-08T11:56:02Z

What

Fixes #10002
Implemented OAuth flow to Snowflake source.

Add option to select authorization method:

Authorization method "Username and password":

Authorization method "OAuth2.0":

How

SourceSnowflakeOAuthFlow.class. Add OAuth flow to make authentication and get access and refresh tokens.
spec.json. Change structure of specification. Added OAuth params. Split authentication methods to provide backward compatibility with username and password authentication.
SourceSnowflake.class. Updated reading configuration due to the new structure of spec.json. Owerrided createDatabase() to use HikariDataSource which has ability to refresh access token for connection pool in execution time.
SnowflakeDataSourceUtils.class. Utility class that has methods to HikariDataSource and refresh token every 7 minutes (access token expires in 10 mins).

🚨 User Impact 🚨

Added new authorization method. The existing auth method (username and password) moved to the bottom of the setting window. User is able to select which authorization method to use.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

...flake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeAccessTokenLoader.java

...source-snowflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeSource.java

alexandr-shegeda · 2022-03-23T12:57:51Z

...source-snowflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeSource.java

    new IntegrationRunner(source).run(args);
+    isSourceAlive = false;


this code doesn't look good, can isSourceAlive and tokenLoader logic be moved in a SnowflakeAccessTokenLoader or to a separate component?

airbyte-oauth/src/test/java/io/airbyte/oauth/flows/SnowflakeOAuthFlowTest.java

alexandr-shegeda · 2022-03-30T10:51:49Z

...owflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeDataSourceUtils.java

+    if (config.has("jdbc_url_params")) {
+      jdbcUrl.append(config.get("jdbc_url_params").asText());
+    }
+    hikariConfig.setJdbcUrl(jdbcUrl.toString());


can you move the logic of the URL building into a separate method? also, it would be great to cover it with some unit tests

alexandr-shegeda · 2022-03-30T10:53:06Z

...owflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeDataSourceUtils.java

+        properties.put("authenticator", "oauth");
+        properties.put("token", accessToken);
+        properties.put("account", config.get("host").asText());
+        hikariConfig.setDataSourceProperties(properties);


can we move properties populating block into a separate method to make it more readable?

yurii-bidiuk · 2022-04-27T12:42:56Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233127088
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233127088
🐛 https://gradle.com/s/sapiavkbi32km

yurii-bidiuk · 2022-04-27T13:01:34Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233217034
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233217034
🐛 https://gradle.com/s/memayqtjo3xc4

yurii-bidiuk · 2022-04-27T13:59:34Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233546282
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233546282
🐛 https://gradle.com/s/b32yp5oc7xuc2

yurii-bidiuk · 2022-04-27T14:18:11Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233662124
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233662124
No Python unittests run

yurii-bidiuk · 2022-04-27T14:38:20Z

/publish connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233784310
🚀 Successfully published connectors/source-snowflake
🚀 Auto-bumped version for connectors/source-snowflake
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/2233784310

* add oauth flow to source-snowflake * Add unit test for oauth flow * add docs to method * format code * change configs * fixed remarks * fixed comments * fixed PR remark * update with master * format code * fix PR remmakrs * add test for backward compatibility * bump version * small fix for test * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

github-actions bot added the area/connectors Connector related issues label Mar 8, 2022

yurii-bidiuk force-pushed the bidiuk/10002-src-snowflake-support-oauth branch 3 times, most recently from 1efdefc to 0bf86fe Compare March 8, 2022 12:06

yurii-bidiuk temporarily deployed to more-secrets March 8, 2022 22:31 Inactive

yurii-bidiuk temporarily deployed to more-secrets March 9, 2022 22:39 Inactive

yurii-bidiuk temporarily deployed to more-secrets March 9, 2022 22:45 Inactive

yurii-bidiuk changed the title ~~[WIP]:🎉 Source Snowflake: support oauth~~ 🎉 Source Snowflake: support oauth Mar 10, 2022

yurii-bidiuk requested review from alexandr-shegeda, etsybaev, sashaNeshcheret and VitaliiMaltsev March 10, 2022 11:02

yurii-bidiuk force-pushed the bidiuk/10002-src-snowflake-support-oauth branch from a3bd575 to 5fdadb2 Compare March 21, 2022 16:40

yurii-bidiuk temporarily deployed to more-secrets March 21, 2022 16:43 Inactive

alexandr-shegeda reviewed Mar 23, 2022

View reviewed changes

...flake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeAccessTokenLoader.java Outdated Show resolved Hide resolved

alexandr-shegeda reviewed Mar 23, 2022

View reviewed changes

...source-snowflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeSource.java Outdated Show resolved Hide resolved

alexandr-shegeda reviewed Mar 23, 2022

View reviewed changes

github-actions bot added the area/documentation Improvements or additions to documentation label Mar 24, 2022

yurii-bidiuk temporarily deployed to more-secrets March 24, 2022 21:22 Inactive

yurii-bidiuk force-pushed the bidiuk/10002-src-snowflake-support-oauth branch from 105fcda to 335cdb3 Compare March 25, 2022 12:21

yurii-bidiuk temporarily deployed to more-secrets March 25, 2022 12:23 Inactive

yurii-bidiuk temporarily deployed to more-secrets March 25, 2022 12:24 Inactive

alexandr-shegeda reviewed Mar 30, 2022

View reviewed changes

airbyte-oauth/src/test/java/io/airbyte/oauth/flows/SnowflakeOAuthFlowTest.java Show resolved Hide resolved

alexandr-shegeda reviewed Mar 30, 2022

View reviewed changes

yurii-bidiuk added 4 commits April 27, 2022 15:19

format code

96a478a

fix PR remmakrs

1ed2613

add test for backward compatibility

f232040

bump version

d84c0cb

yurii-bidiuk force-pushed the bidiuk/10002-src-snowflake-support-oauth branch from 5d58623 to d84c0cb Compare April 27, 2022 12:25

yurii-bidiuk temporarily deployed to more-secrets April 27, 2022 12:28 Inactive

yurii-bidiuk temporarily deployed to more-secrets April 27, 2022 13:03 Inactive

yurii-bidiuk force-pushed the bidiuk/10002-src-snowflake-support-oauth branch from 01268e0 to ff588a2 Compare April 27, 2022 13:59

yurii-bidiuk temporarily deployed to more-secrets April 27, 2022 14:01 Inactive

small fix for test

36af69e

yurii-bidiuk force-pushed the bidiuk/10002-src-snowflake-support-oauth branch from ff588a2 to 36af69e Compare April 27, 2022 14:17

yurii-bidiuk temporarily deployed to more-secrets April 27, 2022 14:19 Inactive

yurii-bidiuk temporarily deployed to more-secrets April 27, 2022 14:20 Inactive

auto-bump connector version

696dc10

octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 14:55 Inactive

octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 14:56 Inactive

yurii-bidiuk merged commit 45a212c into master Apr 27, 2022

yurii-bidiuk deleted the bidiuk/10002-src-snowflake-support-oauth branch April 27, 2022 15:52

octavia-squidington-iii mentioned this pull request Apr 27, 2022

Bump Airbyte version from 0.36.3-alpha to 0.36.4-alpha #12415

Merged

octavia-squidington-iii temporarily deployed to more-secrets April 28, 2022 10:18 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Snowflake: support oauth #10953

🎉 Source Snowflake: support oauth #10953

yurii-bidiuk commented Mar 8, 2022 •

edited

Loading

alexandr-shegeda Mar 23, 2022

yurii-bidiuk Mar 24, 2022

alexandr-shegeda Mar 30, 2022

yurii-bidiuk Apr 1, 2022

alexandr-shegeda Mar 30, 2022

yurii-bidiuk Apr 1, 2022

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

		new IntegrationRunner(source).run(args);
		isSourceAlive = false;

🎉 Source Snowflake: support oauth #10953

🎉 Source Snowflake: support oauth #10953

Conversation

yurii-bidiuk commented Mar 8, 2022 • edited Loading

What

Authorization method "Username and password":

Authorization method "OAuth2.0":

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

alexandr-shegeda Mar 23, 2022

Choose a reason for hiding this comment

yurii-bidiuk Mar 24, 2022

Choose a reason for hiding this comment

alexandr-shegeda Mar 30, 2022

Choose a reason for hiding this comment

yurii-bidiuk Apr 1, 2022

Choose a reason for hiding this comment

alexandr-shegeda Mar 30, 2022

Choose a reason for hiding this comment

yurii-bidiuk Apr 1, 2022

Choose a reason for hiding this comment

yurii-bidiuk commented Apr 27, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 27, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 27, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 27, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 27, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Mar 8, 2022 •

edited

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 27, 2022 •

edited by github-actions bot

Loading