-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install python deps declared in setup.py #1111
Conversation
@@ -1,3 +1,2 @@ | |||
-e ../airbyte-protocol | |||
-e . | |||
dbt==0.18.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think someone put a non-local dependency here, because setup.py wasn't doing the installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I added that there at some point to make some task work somehow... Not sure if you remove it, it's going to do well or not...
The way Airbyte is building python packages is really weird and i don't think it's following proper python recommendations, for example I don't understand why we do some things in setup.py and are using requirements.txt files in this way... (see here
Then lately i also run in such build failures that could be related:
project.task('installReqs', type: PythonTask, dependsOn: project.installLocalReqs) { | ||
module = "pip" | ||
command = "install .[main]" | ||
inputs.file('setup.py') | ||
outputs.file('build/installedreqs.txt') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do these files exist? i haven't been able to find them. pattern matched the naming convention above.
62ed4b2
to
f914d42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue but I think we should consider dropping the [main] convention since it's supposed to be used for extra/truly optional deps whereas everything that goes in main is required for the module to function.
FYI with pants build tool with python, it is geared towards using pex to do this: https://pex.readthedocs.io/en/latest/ |
Relates to #1110
Relates to #1031
What
./gradlew clean build
successfully on my local machine for the last 2 weeks due to the error described here: ./gradlew clean build fails #1031. It seems to be a race condition-y sort of thing that happens when building the whole project.How
Next Steps