Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Intercom stream base url in check connection #11176

Merged
merged 3 commits into from
Mar 22, 2022
Merged

🐛 Fix Intercom stream base url in check connection #11176

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fff2fb
[Bug fix] Intercom stream base url
mrhallak Mar 15, 2022
b985a54
Merge branch 'airbytehq:master' into mrhallak/fix-intercom-stream-bas…
mrhallak Mar 18, 2022
ec92ab6
Restore backslash and use urljoin
mrhallak Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-intercom/source_intercom/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from datetime import datetime
from enum import Enum
from typing import Any, Iterable, List, Mapping, MutableMapping, Optional, Tuple
from urllib.parse import parse_qsl, urlparse
from urllib.parse import parse_qsl, urlparse, urljoin

import requests
from airbyte_cdk.logger import AirbyteLogger
Expand Down Expand Up @@ -413,7 +413,7 @@ class SourceIntercom(AbstractSource):
def check_connection(self, logger, config) -> Tuple[bool, any]:
authenticator = VersionApiAuthenticator(token=config["access_token"])
try:
url = f"{IntercomStream.url_base}/tags"
url = urljoin(IntercomStream.url_base, "/tags")
auth_headers = {"Accept": "application/json", **authenticator.get_auth_header()}
session = requests.get(url, headers=auth_headers)
session.raise_for_status()
Expand Down