Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Google Sheets: add missing titles and descriptions to fields in connector spec #11270

Merged
merged 2 commits into from
Mar 23, 2022
Merged

🐛 Source Google Sheets: add missing titles and descriptions to fields in connector spec #11270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6524b2
Remove copy-pasta comment from another connector
Mar 18, 2022
f1805ae
Spec cleanup
Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion airbyte-integrations/connectors/source-google-sheets/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ tests:
discovery:
- config_path: "secrets/service_config.json"
basic_read:
# Sometimes test could fail (on weekends) because transactions could temporary disappear from Paypal Sandbox account
- config_path: "secrets/service_config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
full_refresh:
Expand Down
5 changes: 4 additions & 1 deletion airbyte-integrations/connectors/source-google-sheets/google_sheets_source/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@
"spreadsheet_id": {
"type": "string",
"title": "Spreadsheet ID",
"description": "The ID of the spreadsheet to be replicated."
"description": "The ID of the spreadsheet to be replicated. The ID is found in the URL of your spreadsheet, typically between \"/d/\" and \"/edit\"",
"examples": ["1hLd9Qqti5XyLXZB2aFfUWDT7BG-arw2xy4HR3D-dwUb"]
},
"credentials": {
"type": "object",
"title": "Credentials",
"description": "Google API Credentials for connecting to Google Sheets and Google Drive APIs",
"oneOf": [
{
"title": "Authenticate via Google (OAuth)",
Expand Down