Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Bing Ads: add Redirect URI & Tenant ID to spec #11311

Merged
merged 4 commits into from
Mar 31, 2022
Merged

🎉 Source Bing Ads: add Redirect URI & Tenant ID to spec #11311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fad16b
bing ads: add redirect_uri to spec
alexbondar92 Mar 22, 2022
9b01ecc
address cr comments
alexbondar92 Mar 23, 2022
808755c
Merge branch 'airbytehq:master' into bing-add-redirect-uri
alexbondar92 Mar 30, 2022
b6244f3
Merge branch 'airbytehq:master' into bing-add-redirect-uri
alexbondar92 Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
- name: Bing Ads
sourceDefinitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerRepository: airbyte/source-bing-ads
dockerImageTag: 0.1.3
dockerImageTag: 0.1.4
documentationUrl: https://docs.airbyte.io/integrations/sources/bing-ads
icon: bingads.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.3
LABEL io.airbyte.version=0.1.4
LABEL io.airbyte.name=airbyte/source-bing-ads
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-bing-ads/integration_tests/invalid_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
"refresh_token": "as2Ggas23gsa236gasgaskjfhas7i8ygf78as7osa7gy87asg8as7tg6as",
"client_secret": "1234",
"client_id": "123",
"tenant_id": "common",
"redirect_uri": "",
"reports_start_date": "2018-11-13",
"hourly_reports": true,
"daily_reports": false,
Expand Down
5 changes: 4 additions & 1 deletion airbyte-integrations/connectors/source-bing-ads/source_bing_ads/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ def __init__(
customer_id: str,
client_secret: str,
client_id: str,
tenant_id: str,
alafanechere marked this conversation as resolved.
Show resolved Hide resolved
redirect_uri: str,
refresh_token: str,
reports_start_date: str,
hourly_reports: bool,
Expand All @@ -52,7 +54,8 @@ def __init__(
self.authentication = OAuthWebAuthCodeGrant(
client_id,
client_secret,
"",
redirect_uri,
tenant=tenant_id,
)

self.refresh_token = refresh_token
Expand Down
14 changes: 14 additions & 0 deletions airbyte-integrations/connectors/source-bing-ads/source_bing_ads/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,20 @@
"description": "Developer token associated with user.",
"airbyte_secret": true
},
"tenant_id": {
"type": "string",
"title": "Tenant ID",
"description": "The Tenant ID of your Microsoft Advertising developer application.",
"airbyte_secret": true,
"default": "common"
},
"redirect_uri": {
"type": "string",
"title": "Redirect URI",
"description": "The Redirect URI of your Microsoft Advertising developer application.",
"airbyte_secret": true,
"default": ""
},
"refresh_token": {
"type": "string",
"title": "Refresh Token",
Expand Down
3 changes: 3 additions & 0 deletions docs/integrations/sources/bing-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ API limits number of requests for all Microsoft Advertising clients. You can fin
* refresh\_token: Token received during [auth process](https://docs.microsoft.com/en-us/advertising/guides/authentication-oauth?view=bingads-13)
* client\_secret: Secret generated during application registration
* client\_id: Id generated during application registration
* tenant_id: Tenant generated during application registration
* redirect\_uri: You can create Redirect URI from azure application configuration. e.g: https://login.microsoftonline.com/{tenant_id}/oauth2/nativeclient
* reports\_start\_date: From which date report generation should start
* report\_aggregation: Defines how report data will be aggregated
* hourly\_reports: includes hourly report streams if true
Expand All @@ -77,6 +79,7 @@ Be aware that `refresh token` will expire in 90 days. You need to repeat auth pr

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.4 | 2022-03-22 | [9510](https://github.com/airbytehq/airbyte/pull/9510) | Added optional Redirect URI & Tenant ID to spec |
| 0.1.3 | 2022-01-14 | [9510](https://github.com/airbytehq/airbyte/pull/9510) | Fixed broken dependency that blocked connector's operations |
| 0.1.2 | 2021-12-14 | [8429](https://github.com/airbytehq/airbyte/pull/8429) | Update titles and descriptions |
| 0.1.1 | 2021-08-31 | [5750](https://github.com/airbytehq/airbyte/pull/5750) | Added reporting streams\) |
Expand Down