-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant/Revoke workspace definition grants #11338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
issues related to the platform
area/server
labels
Mar 23, 2022
given an actor definition id and workspace id
git-phu
force-pushed
the
peter/grant-definitions-to-workspaces
branch
from
March 23, 2022 21:18
cf61538
to
515f277
Compare
pmossman
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one suggestion for Jooq query style
airbyte-config/persistence/src/main/java/io/airbyte/config/persistence/ConfigRepository.java
Outdated
Show resolved
Hide resolved
git-phu
force-pushed
the
peter/grant-definitions-to-workspaces
branch
from
March 23, 2022 22:56
6bc6fe6
to
68ce286
Compare
…t-definitions-to-workspaces # Conflicts: # airbyte-config/persistence/src/main/java/io/airbyte/config/persistence/ConfigRepository.java # airbyte-config/persistence/src/test/java/io/airbyte/config/persistence/ConfigRepositoryE2EReadWriteTest.java
This was referenced Mar 24, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #9652
Tech Spec
Implements routes to grant or revoke workspace definition grants. Depends on #11305
Recommended reading order
Easiest to view by commit
User Impact
Doesn't change the behavior of existing routes