Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant/Revoke workspace definition grants #11338

Merged
merged 10 commits into from
Mar 24, 2022

Conversation

git-phu
Copy link
Contributor

@git-phu git-phu commented Mar 23, 2022

What

Part of #9652
Tech Spec

Implements routes to grant or revoke workspace definition grants. Depends on #11305

Recommended reading order

Easiest to view by commit

User Impact

Doesn't change the behavior of existing routes

@github-actions github-actions bot added area/platform issues related to the platform area/server labels Mar 23, 2022
@git-phu git-phu temporarily deployed to more-secrets March 23, 2022 02:30 Inactive
@git-phu git-phu temporarily deployed to more-secrets March 23, 2022 02:30 Inactive
@git-phu git-phu force-pushed the peter/grant-definitions-to-workspaces branch from cf61538 to 515f277 Compare March 23, 2022 21:18
@git-phu git-phu marked this pull request as ready for review March 23, 2022 21:20
@git-phu git-phu requested a review from pmossman March 23, 2022 21:20
Copy link
Contributor

@pmossman pmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one suggestion for Jooq query style

@git-phu git-phu force-pushed the peter/grant-definitions-to-workspaces branch from 6bc6fe6 to 68ce286 Compare March 23, 2022 22:56
…t-definitions-to-workspaces

# Conflicts:
#	airbyte-config/persistence/src/main/java/io/airbyte/config/persistence/ConfigRepository.java
#	airbyte-config/persistence/src/test/java/io/airbyte/config/persistence/ConfigRepositoryE2EReadWriteTest.java
@git-phu git-phu temporarily deployed to more-secrets March 23, 2022 23:38 Inactive
@git-phu git-phu temporarily deployed to more-secrets March 23, 2022 23:38 Inactive
@git-phu git-phu temporarily deployed to more-secrets March 24, 2022 00:50 Inactive
@git-phu git-phu temporarily deployed to more-secrets March 24, 2022 00:50 Inactive
@git-phu git-phu merged commit 05b816d into master Mar 24, 2022
@git-phu git-phu deleted the peter/grant-definitions-to-workspaces branch March 24, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants