-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Mailchimp: update documentation #11352
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11352 +/- ##
=========================================
Coverage ? 94.66%
=========================================
Files ? 3
Lines ? 150
Branches ? 0
=========================================
Hits ? 142
Misses ? 8
Partials ? 0 Continue to review full report at Codecov.
|
…imp-docs # Conflicts: # docs/integrations/sources/mailchimp.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments and feedback.
FYI @andyjih
Co-authored-by: Andy <andy@airbyte.io>
Co-authored-by: Andy <andy@airbyte.io>
Co-authored-by: Andy <andy@airbyte.io>
Co-authored-by: Andy <andy@airbyte.io>
Co-authored-by: Andy <andy@airbyte.io>
Co-authored-by: Andy <andy@airbyte.io>
Co-authored-by: Andy <andy@airbyte.io>
/test connector=connectors/source-mailchimp
|
/publish connector=connectors/source-mailchimp
|
/publish connector=connectors/source-mailchimp
|
* update doc * bump version * upd doc * update doc * Update docs/integrations/sources/mailchimp.md Co-authored-by: Andy <andy@airbyte.io> * Update docs/integrations/sources/mailchimp.md Co-authored-by: Andy <andy@airbyte.io> * Update docs/integrations/sources/mailchimp.md Co-authored-by: Andy <andy@airbyte.io> * Update docs/integrations/sources/mailchimp.md Co-authored-by: Andy <andy@airbyte.io> * Update docs/integrations/sources/mailchimp.md Co-authored-by: Andy <andy@airbyte.io> * Update docs/integrations/sources/mailchimp.md Co-authored-by: Andy <andy@airbyte.io> * update doc * Update docs/integrations/sources/mailchimp.md Co-authored-by: Andy <andy@airbyte.io> * auto-bump connector version Co-authored-by: Andy <andy@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Close #11347
How
Update documentation
Recommended reading order
spec.json
mailchimp.md
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.