🐛 Source Titok marketing: update schema. add unittest, update SAT, fix initialization for Audience streams #11378

midavadim · 2022-03-23T23:29:13Z

Engineering Acceptance Criteria:

Source Tiktok Marketing: have at least 90% unit test coverage #11372
Source Tiktok Marketing: add missing streams in SAT #11376
Source Tiktok marketing: add SAT tests for DAY, HOUR granularity #11377

Outstanding bugs:

Source Tiktok: data type error for mobile_app_id field in ads_reports_metrics and ad_groups_reports_metrics #9709
Source Tiktok: wrong type in campaign schema #9491
Round value of source attribute with type "integer" #6875
Source Tiktok: fix metrix for LIFETIME granularity #11375
Source Titok marketing: discovery method is too long (~ 40 seconds) #12107

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-03-23T23:29:20Z

All committers have signed the CLA.

…, basic_resports, audience_reports) with DAY and LIFETIME granularities. Advertizer ids are extracted only during read method, previously ids were extracted during stream initialization. Added caching for AdvertizerIds stream

…hema-fix

bazarnov · 2022-04-13T17:40:21Z

airbyte-integrations/connectors/source-tiktok-marketing/acceptance-test-config.yml

+    - config_path: "secrets/prod_config_day.json"
+      configured_catalog_path: "integration_tests/streams_all.json"
+      timeout_seconds: 1200
+      validate_schema: false  # validation fails for audience report streams


Are we aware of what exactly is wrong with the validation of Audience Report streams?

bazarnov · 2022-04-13T17:41:28Z

...ons/connectors/source-tiktok-marketing/source_tiktok_marketing/schemas/audience_reports.json

-        "cash_spend": {
-          "type": ["null", "number"]
-        },
-        "voucher_spend": {
-          "type": ["null", "number"]
-        },


Is there any valid reason we removed this from the schema?

bazarnov · 2022-04-13T17:44:29Z

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/streams.py

@@ -108,6 +114,14 @@ class TiktokStream(HttpStream, ABC):
    # max value of page
    page_size = 1000

+    def __init__(self, **kwargs):
+        super().__init__(authenticator=kwargs.get("authenticator"))


Do we need to call authenticator directly here? I believe it should be passed automatically if we have such a property inside the passing args. Please check.

midavadim · 2022-04-18T17:55:57Z