Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source Intercom: increase unit test coverage at least 90% #11405

Merged
merged 12 commits into from
Mar 28, 2022

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Mar 24, 2022

What

#11364 - Source Intercom: increase unit test coverage at least 90%

How

Increased unit test coverage to 90%

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 24, 2022
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 24, 2022

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/2035746497
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/2035746497
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/source.py       226     44    81%
-------------------------------------------------
TOTAL                           228     44    81%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/source.py       226     21    91%
-------------------------------------------------
TOTAL                           228     21    91%

@lazebnyi lazebnyi changed the title Source Intercom: increase unit test coverage at least 90% 🎉Source Intercom: increase unit test coverage at least 90% Mar 24, 2022
@lazebnyi lazebnyi marked this pull request as ready for review March 25, 2022 12:19
docs/integrations/sources/intercom.md Outdated Show resolved Hide resolved
docs/integrations/sources/intercom.md Outdated Show resolved Hide resolved
docs/integrations/sources/intercom.md Outdated Show resolved Hide resolved
docs/integrations/sources/intercom.md Outdated Show resolved Hide resolved
@lazebnyi lazebnyi removed the request for review from ChristopheDuong March 28, 2022 10:39
lazebnyi and others added 7 commits March 28, 2022 13:39
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@lazebnyi lazebnyi merged commit 3f50396 into master Mar 28, 2022
@lazebnyi lazebnyi deleted the lazebnyi/11364-intercom-unit-test-coverage-to-90 branch March 28, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Intercom: updated doc for OAuth Source Intercom: increase unit test coverage at least 90%
4 participants