Increase number of attempts to 20 #11446

girarda · 2022-03-25T22:01:17Z

What

Increase number of retries on each FB job to help with https://github.com/airbytehq/oncall/issues/176

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

girarda · 2022-03-25T22:01:49Z

.../connectors/source-facebook-marketing/source_facebook_marketing/streams/async_job_manager.py

@@ -25,7 +25,7 @@ class InsightAsyncJobManager:

    # When current insights throttle hit this value no new jobs added.
    THROTTLE_LIMIT = 70
-    MAX_NUMBER_OF_ATTEMPTS = 5
+    MAX_NUMBER_OF_ATTEMPTS = 20


went straight to 4x because we don't have a good way to reproduce the issue

codecov · 2022-03-25T22:08:02Z

Codecov Report

❗ No coverage uploaded for pull request base (master@848bb34). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11446   +/-   ##
=========================================
  Coverage          ?   90.59%           
=========================================
  Files             ?       11           
  Lines             ?      840           
  Branches          ?        0           
=========================================
  Hits              ?      761           
  Misses            ?       79           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848bb34...47918ca. Read the comment docs.

girarda · 2022-03-25T22:09:11Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2042476093
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2042476093
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                               97     13    87%
source_facebook_marketing/streams/base_streams.py             127     27    79%
source_facebook_marketing/streams/common.py                    41     13    68%
source_facebook_marketing/streams/streams.py                   97     32    67%
source_facebook_marketing/source.py                            35     13    63%
source_facebook_marketing/streams/base_insight_streams.py     129     54    58%
source_facebook_marketing/streams/async_job.py                204    128    37%
source_facebook_marketing/streams/async_job_manager.py         74     56    24%
-------------------------------------------------------------------------------
TOTAL                                                         841    336    60%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                204      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/source.py                            35      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    41      1    98%
source_facebook_marketing/streams/async_job_manager.py         74      3    96%
source_facebook_marketing/streams/base_insight_streams.py     129     13    90%
source_facebook_marketing/api.py                               97     16    84%
source_facebook_marketing/streams/streams.py                   97     22    77%
source_facebook_marketing/streams/base_streams.py             127     30    76%
-------------------------------------------------------------------------------
TOTAL                                                         841     85    90%

girarda · 2022-03-28T15:43:01Z

/test publish=connectors/source-facebook-marketing

Error: Unexpected inputs provided: ["publish"]

girarda · 2022-03-28T15:46:00Z

/publish connector=connectors/source-facebook-marketing

girarda · 2022-03-28T16:01:52Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2053446980
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2053446980

girarda · 2022-03-28T16:14:19Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2053515410
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2053515410

github-actions bot added the area/connectors Connector related issues label Mar 25, 2022

girarda commented Mar 25, 2022

View reviewed changes

github-actions bot referenced this pull request Mar 25, 2022

Increase number of attempts to 20

a31aa5e

girarda requested a review from ChristopheDuong March 25, 2022 22:52

ChristopheDuong approved these changes Mar 28, 2022

View reviewed changes

Increase number of attempts to 20

4dafa19

girarda force-pushed the alex/facebookRetries branch from a31aa5e to 4dafa19 Compare March 28, 2022 15:41

Bump version

5ccae55

Update docs

4a55999

github-actions bot added the area/documentation Improvements or additions to documentation label Mar 28, 2022

girarda temporarily deployed to more-secrets March 28, 2022 15:47 Inactive

Bump version in dockerfile

c369ff9

Update specs

47918ca

girarda temporarily deployed to more-secrets March 28, 2022 16:47 Inactive

girarda merged commit ec27d81 into master Mar 28, 2022

girarda deleted the alex/facebookRetries branch March 28, 2022 18:04

octavia-squidington-iii mentioned this pull request Mar 28, 2022

Bump Airbyte version from 0.35.60-alpha to 0.35.61-alpha #11478

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase number of attempts to 20 #11446

Increase number of attempts to 20 #11446

girarda commented Mar 25, 2022 •

edited

Loading

girarda Mar 25, 2022

codecov bot commented Mar 25, 2022 •

edited

Loading

girarda commented Mar 25, 2022 •

edited by github-actions bot

Loading

girarda commented Mar 28, 2022 •

edited by github-actions bot

Loading

girarda commented Mar 28, 2022

girarda commented Mar 28, 2022 •

edited by github-actions bot

Loading

girarda commented Mar 28, 2022 •

edited by github-actions bot

Loading

Increase number of attempts to 20 #11446

Increase number of attempts to 20 #11446

Conversation

girarda commented Mar 25, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

girarda Mar 25, 2022

Choose a reason for hiding this comment

codecov bot commented Mar 25, 2022 • edited Loading

Codecov Report

girarda commented Mar 25, 2022 • edited by github-actions bot Loading

girarda commented Mar 28, 2022 • edited by github-actions bot Loading

girarda commented Mar 28, 2022

girarda commented Mar 28, 2022 • edited by github-actions bot Loading

girarda commented Mar 28, 2022 • edited by github-actions bot Loading

girarda commented Mar 25, 2022 •

edited

Loading

codecov bot commented Mar 25, 2022 •

edited

Loading

girarda commented Mar 25, 2022 •

edited by github-actions bot

Loading

girarda commented Mar 28, 2022 •

edited by github-actions bot

Loading

girarda commented Mar 28, 2022 •

edited by github-actions bot

Loading

girarda commented Mar 28, 2022 •

edited by github-actions bot

Loading