Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the build tokens and use the OSS build runner. #11451

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

davinchia
Copy link
Contributor

What

Similar to https://github.com/airbytehq/airbyte-cloud/pull/1271.

Remove the octavia build token. Use the OSS build token.

After this change:

  • Make it so the connector_base, frontend_build and platform_build are on airbyteio pat.
  • The rest of the builds are on the oss build runner pat.
  • Davin's tokens are used for the slash command builds.
  • Octavia token is only used for administrative stuff.

How

Do the above.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…he connector_base, frontend_build and platform_build are on airbyteio. The rest of the builds are on the oss build runner.
@davinchia
Copy link
Contributor Author

Evidence that airbyteio pat is used only for the main build:
Screen Shot 2022-03-26 at 5 21 59 PM

@davinchia
Copy link
Contributor Author

Evidence the oss build runner token only used for the build

Screen Shot 2022-03-26 at 5 22 48 PM

@davinchia
Copy link
Contributor Author

Evidence octavia token is removed:

Screen Shot 2022-03-26 at 5 24 14 PM

@davinchia
Copy link
Contributor Author

fyi @supertopher

@davinchia davinchia merged commit 931694d into master Mar 28, 2022
@davinchia davinchia deleted the davinchia/use-oss-build-runner-pat branch March 28, 2022 05:09
@supertopher
Copy link
Contributor

is SELF_RUNNER_GITHUB_ACCESS_TOKEN_1 still your token? I think we should reflect that in the naming so the information isn't silo-ed. not necessarily this second of anything but sometime

@davinchia
Copy link
Contributor Author

No that was Octavia's token. I've removed it for now. The one that is my token is SELF_RUNNER_GITHUB_ACCESS_TOKEN. Agree with you. Will find time to change this today or tmrw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants