-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 source Salesloft: added several new streams #11460
🎉 source Salesloft: added several new streams #11460
Conversation
@yannibenoit ping me when this is ready to review. |
Warning: there are some API Limits errors but sync went well :)
|
Needed to edit next_page_token method to check if paging key was available in response metadata because that cause the sync stream error below
|
@marcosmarxm it's good for review now |
/test connector=connectors/source-salesloft
|
/publish connector=connectors/source-salesloft auto-bump-version=false
|
Thank you @yannibenoit for this big improvement! |
What
New sources added for Salesloft integration ->
How
For each new stream :
IncrementalSalesloftStream
orSalesloftStream
classstreams
method inSourceSalesloft
class to add new class in returntest_source.py
to allow one more stream when unit testingRecommended reading order
emails.json
account_stages.json
account_tiers.json
accounts.json
actions.json
calls.json
email_templates.json
import.json
notes.json
person_stages.json
phone_number_assignments.json
steps.json
team_templates.json
groups.json
crm_activities.json
crm_users.json
email_template_attachments.json
team_template_attachments.json
successes.json
source.py
test_source.py
🚨 User Impact 🚨
New streams will be available in connector settings
New tables will be available in destination
**
**
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.