Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor notification resource to use react-query #11476

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Refactor notification resource to use react-query #11476

merged 1 commit into from
Mar 30, 2022

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented Mar 28, 2022 •
edited
Loading

What

Moves notifications API usage from rest-hooks to react-query.

Part of #10400

@jamakase jamakase requested a review from a team as a code owner March 28, 2022 18:20
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Mar 28, 2022
@jamakase jamakase self-assigned this Mar 28, 2022
timroes
timroes approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Not tested locally.

@jamakase jamakase merged commit 6db7a28 into master Mar 30, 2022
@jamakase jamakase deleted the jamakase/move-notifications-to-react-query branch March 30, 2022 11:33
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees

@jamakase jamakase

Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamakase @timroes