-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Amazon Ads: Update fields in source-connectors specifications #11730
Conversation
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/source-amazon-ads
|
Codecov Report
@@ Coverage Diff @@
## master #11730 +/- ##
=========================================
Coverage ? 98.79%
=========================================
Files ? 22
Lines ? 663
Branches ? 0
=========================================
Hits ? 655
Misses ? 8
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/source-amazon-ads
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/source-amazon-ads
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't hear back from you on Slack @grubberr - can you make sure to respond there about how we're automatically adding the asterisks and why it's not consistent across the fields?
Approving this based on what's been shown in the screenshot.
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
…d (2) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
… required (2)" This reverts commit 089dbec.
… required" This reverts commit de6dbab.
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/source-amazon-ads
|
/publish connector=connectors/source-amazon-ads
|
…11730) * Update fields in source-connectors specifications Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk grubberr@gmail.com
What
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.