Upgrade to Python 3.9 #11763
Upgrade to Python 3.9 #11763
Conversation
github-actions
bot
added
area/connectors
|
As a start, I ran all the Here are the ones that failed: Summary: source-appstore-singer: can't install cryptography source-zoom-singer: version mismatches source-tiktok-marketing: expects secrets file source-yahoo-finance-price: tests failing destination-aws-datalake: no unit test source-google-ads: expects secrets file source-monday: expects secrets file source-dixa: timing differences in unit test source-snapchat-marketing: expects secrets file source-appsflyer-singer: version conflict source-s3: install issue source-file-secure: install issue |
|
/test connector=source-airtable
|
|
/test connector=source-airtable
|
|
/test connector=source-airtable
|
|
/test connector=source-asana ref=bl-python-39
|
|
/test connector=all ref=bl-python-39
|
|
/test connector=all ref=bl-python-39
|
|
/test connector=source-airtable ref=bl-python-39
|
Codecov Report
@@ Coverage Diff @@
## master airbytehq/airbyte#11763 +/- ##
=========================================
Coverage ? 77.90%
=========================================
Files ? 86
Lines ? 4385
Branches ? 0
=========================================
Hits ? 3416
Misses ? 969
Partials ? 0 Continue to review full report at Codecov.
|
| - uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: "3.8" | ||
| python-version: "3.9" |
There was a problem hiding this comment.
nice! heads up @alafanechere
| python_version: '3.7.9' | ||
| pip_version: '21.1' | ||
| subdir: 'airbyte-cdk/python/' | ||
| python_version: "3.9.11" |
There was a problem hiding this comment.
is it worth standardising on 3.9.11/3.9 everywhere?
There was a problem hiding this comment.
I think I have. Did I miss one?
Or are you saying not to change this one? I was following the hint on line 76 there.
There was a problem hiding this comment.
I was wondering out loud whether it's worth standardising the entire repo to 3.9.11 instead of having 3.9.11 here and 3.9 on the connectors.
| @@ -1 +1 @@ | |||
| 3.8.12 | |||
| 3.9.11 | |||
There was a problem hiding this comment.
@alafanechere I'm not sure if this file is needed or not now that they are the same. Can you follow up and check once this is merged?
There was a problem hiding this comment.
Cool, I could now use 3.9.11 now indeed.
Previous example (source-google-search-console/credentials)
|
Is it desirable to have all connectors on one Python version @davinchia? I put this up a while ago in attempt to do what you brought up (bring standardization to versions) but got blocked from merging on past employer rules that no longer apply to me :D I'll pick that up again and maybe add in a way to apply the python version to the Dockerfiles if that is wanted |
|
@noahkawasaki-airbyte not a strict guideline, but definitely we should try our best to do so to keep things simple. I'll defer to @sherifnada on the exact details. I remember your pr :) |
|
@noahkawasaki-airbyte I think it's desirable as long as there is a way to easily express exceptions e.g: there may be one straggler package which can't work with that version, in which case it needs to be trivial to switch that one over imo |
What
Investigating #11657 to upgrade Python to 3.9
How
Change all the 3.7 to 3.9 and run the tests
🚨 User Impact 🚨
There may be some python connectors with issues that we'll need to update.
Pre-merge Checklist
Expand the relevant checklist and delete the others.