Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to block navigation when forms have not been saved #11831

Merged
merged 14 commits into from
Apr 20, 2022
Merged

Add the ability to block navigation when forms have not been saved #11831

merged 14 commits into from
Apr 20, 2022

Commits on Apr 18, 2022

  1. Add navigation blocking when forms are dirty and not saved 

    * Add hooks to block and display prompt on navigation
* Add components to indicate which form is blocking
* Update connection replication and transformation components to block on edit
* Update main page component to show prompt
    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    1d95d1f View commit details
    Browse the repository at this point in the history

  2. Add Confimration Modal and Service and update form blocking to use modal

    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    78a1829 View commit details
    Browse the repository at this point in the history

  3. FormNavigationBlocker -> FormChangesTracker 

    useFormNavigationBlocking -> useDiscardFormChangesConfirmation
Update exports from default to module
    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    341f4dd View commit details
    Browse the repository at this point in the history

  4. Add confirmation modal text to i18n file

    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    362d1aa View commit details
    Browse the repository at this point in the history

  5. Used formatted title in ConfirmationModal component

    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    c625690 View commit details
    Browse the repository at this point in the history

  6. Move Form change tracking to a service pattern 

    Fix forms in replications and transformations not resetting the data
Add types to import sorting and add Formik helper type for onSubmit functions
    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    cd21133 View commit details
    Browse the repository at this point in the history

  7. Clear all form data after submission in ConnectionForm component 

    Update ConnectionForm submission to handle post submission result from callback
    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    2bd5419 View commit details
    Browse the repository at this point in the history

  8. ConnectionForm now clears its own form tracking 

    Add hook to generate unique form id
Update form tracker component to use new hook if no id is specified
    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    ba5b3b9 View commit details
    Browse the repository at this point in the history

  9. Adjust margins on ConfirmationModal to more closely match design

    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9d4fa10 View commit details
    Browse the repository at this point in the history

  10. Update useUniqueFormId hook id generation to exclude trailing slash

    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    e2a42af View commit details
    Browse the repository at this point in the history

  11. Cleanup code based on pull request review

    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    53fdc84 View commit details
    Browse the repository at this point in the history

  12. Remove uneeded dependency spread in useConfirmationModalService hook

    @edmundito
    edmundito committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    69ba07b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Remove data-id from confirmation modal component 

    Update FormChangeTracker to useEffect over useLayoutEffect
Memoize useConfirmationModalService hook
Remove memoization of ConfirmationModalService provider
Simplify useUniqueFormId
    @edmundito
    edmundito committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    fae55d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Update FormTrackerService check from reduce to some 

    Co-authored-by: Tim Roes <tim@airbyte.io>
    @edmundito @timroes
    edmundito and timroes authored Apr 20, 2022
    Configuration menu
    Copy the full SHA
    3c76502 View commit details
    Browse the repository at this point in the history