-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Smartsheets: fix scrambled columns bug #11911
🐛 Source Smartsheets: fix scrambled columns bug #11911
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11911 +/- ##
=========================================
Coverage ? 45.20%
=========================================
Files ? 2
Lines ? 73
Branches ? 0
=========================================
Hits ? 33
Misses ? 40
Partials ? 0 Continue to review full report at Codecov.
|
/test connnector=connectors/source-smartsheets
|
/test connector=connectors/source-smartsheets
|
/test connector=connectors/source-smartsheets
|
airbyte-integrations/connectors/source-smartsheets/unit_tests/test_source.py
Show resolved
Hide resolved
/test connector=connectors/source-smartsheets
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update can be released without Airbyte review
/publish connector=connectors/source-smartsheets
|
* #5520 fix scrambled columns bug * #5520 source smartsheets: add changelog item * #5520 move pytest to optional setup requirements * #5520 source smartsheets: add two unit tests * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
#5520
#8099
Moving
email
column in the UI to the last position and performingread
gives following results:How
Stream
instance, useSheet
instance insteadcolumnId
pip install
)