S3 destination: updating specs regarding certification #11917

sashaNeshcheret · 2022-04-12T11:26:04Z

What

We updated specs regarding certification

How

We added * or 'Optional' to fields names, reordered fields.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

sashaNeshcheret · 2022-04-18T17:05:09Z

@misteryeo, could you take a look.

airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json

misteryeo · 2022-04-20T19:00:50Z

airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json

@@ -16,33 +16,34 @@
    ],
    "additionalProperties": false,
    "properties": {
-      "s3_endpoint": {
-        "title": "Endpoint",
+      "access_key_id": {


For all of these fields, where are the relevant docs linked so a user can find more information as part of this checklist item?

Added links for required and optional first level fields.

misteryeo · 2022-04-20T19:01:14Z

airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json

              },
              "part_size_mb": {
-                "title": "Block Size (MB) for Amazon S3 multipart upload",
+                "title": "dddBlock Size (MB) for Amazon S3 multipart upload (Optional)",


I think you added some random 'd's to this description?

Seems yes, it was attempt to recognize whether specs is reloaded.

Co-authored-by: Andy <andy@airbyte.io>

…s3-destination-spec-update

…n-spec-update' into omneshcheret/11835-s3-destination-spec-update

misteryeo

Still don't see relevant docs linked in descriptions and left a few more comments.

airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json

Co-authored-by: Andy <andy@airbyte.io>

misteryeo

Just one suggestion otherwise good to go!

misteryeo · 2022-04-29T19:31:10Z

airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json

        "type": "object",
-        "description": "Output data format",
+        "description": "Output data format See [here](https://docs.airbyte.com/integrations/destinations/s3/#output-schema) for more details",


Suggested change

"description": "Output data format See [here](https://docs.airbyte.com/integrations/destinations/s3/#output-schema) for more details",

"description": "Format of the data output. See [here](https://docs.airbyte.com/integrations/destinations/s3/#output-schema) for more details",

* S3 destination: updating specs regarding certification * S3 destination: updating required fields * S3 destination: updating required fields * Apply suggestions from code review Co-authored-by: Andy <andy@airbyte.io> * S3 destination: updating specs with links * S3 destination: updating specs with links * Apply suggestions from code review Co-authored-by: Andy <andy@airbyte.io> * S3 destination: added links to the fields * S3 destination: updating specs with links Co-authored-by: Andy <andy@airbyte.io>

S3 destination: updating specs regarding certification

3baf426

github-actions bot added the area/connectors Connector related issues label Apr 12, 2022

sashaNeshcheret requested a review from misteryeo April 12, 2022 11:29

sashaNeshcheret linked an issue Apr 12, 2022 that may be closed by this pull request

S3 destination: update spec regarding certification checklist #11835

Closed

sashaNeshcheret added 2 commits April 12, 2022 20:40

S3 destination: updating required fields

6bb7afe

S3 destination: updating required fields

8980a0e

misteryeo suggested changes Apr 20, 2022

View reviewed changes

sashaNeshcheret and others added 5 commits April 25, 2022 15:31

Apply suggestions from code review

ef28540

Co-authored-by: Andy <andy@airbyte.io>

Merge remote-tracking branch 'origin/master' into omneshcheret/11835-…

7151d5e

…s3-destination-spec-update

Merge remote-tracking branch 'origin/omneshcheret/11835-s3-destinatio…

8d4e61d

…n-spec-update' into omneshcheret/11835-s3-destination-spec-update

S3 destination: updating specs with links

bc20abb

S3 destination: updating specs with links

de4aa79

sashaNeshcheret requested a review from misteryeo April 27, 2022 08:42

misteryeo suggested changes Apr 27, 2022

View reviewed changes

airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json Outdated Show resolved Hide resolved

airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json Outdated Show resolved Hide resolved

sashaNeshcheret and others added 2 commits April 29, 2022 18:20

Apply suggestions from code review

a1e7220

Co-authored-by: Andy <andy@airbyte.io>

S3 destination: added links to the fields

97bd0ce

sashaNeshcheret requested a review from misteryeo April 29, 2022 15:56

misteryeo approved these changes Apr 29, 2022

View reviewed changes

S3 destination: updating specs with links

cffca0b

sashaNeshcheret merged commit 3ab0899 into master May 3, 2022

sashaNeshcheret deleted the omneshcheret/11835-s3-destination-spec-update branch May 3, 2022 10:42

octavia-squidington-iii mentioned this pull request May 3, 2022

Bump Airbyte version from 0.36.6-alpha to 0.36.7-alpha #12535

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

S3 destination: updating specs regarding certification #11917

S3 destination: updating specs regarding certification #11917

sashaNeshcheret commented Apr 12, 2022

sashaNeshcheret commented Apr 18, 2022

misteryeo Apr 20, 2022

sashaNeshcheret Apr 29, 2022 •

edited

Loading

misteryeo Apr 20, 2022

sashaNeshcheret Apr 25, 2022

misteryeo left a comment

misteryeo left a comment

misteryeo Apr 29, 2022

	"description": "Output data format See [here](https://docs.airbyte.com/integrations/destinations/s3/#output-schema) for more details",
	"description": "Format of the data output. See [here](https://docs.airbyte.com/integrations/destinations/s3/#output-schema) for more details",

S3 destination: updating specs regarding certification #11917

S3 destination: updating specs regarding certification #11917

Conversation

sashaNeshcheret commented Apr 12, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

sashaNeshcheret commented Apr 18, 2022

misteryeo Apr 20, 2022

Choose a reason for hiding this comment

sashaNeshcheret Apr 29, 2022 • edited Loading

Choose a reason for hiding this comment

misteryeo Apr 20, 2022

Choose a reason for hiding this comment

sashaNeshcheret Apr 25, 2022

Choose a reason for hiding this comment

misteryeo left a comment

Choose a reason for hiding this comment

misteryeo left a comment

Choose a reason for hiding this comment

misteryeo Apr 29, 2022

Choose a reason for hiding this comment

sashaNeshcheret Apr 29, 2022 •

edited

Loading