-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 destination: updating specs regarding certification #11917
S3 destination: updating specs regarding certification #11917
Conversation
@misteryeo, could you take a look. |
airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
@@ -16,33 +16,34 @@ | |||
], | |||
"additionalProperties": false, | |||
"properties": { | |||
"s3_endpoint": { | |||
"title": "Endpoint", | |||
"access_key_id": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of these fields, where are the relevant docs linked so a user can find more information as part of this checklist item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added links for required and optional first level fields.
}, | ||
"part_size_mb": { | ||
"title": "Block Size (MB) for Amazon S3 multipart upload", | ||
"title": "dddBlock Size (MB) for Amazon S3 multipart upload (Optional)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you added some random 'd's to this description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems yes, it was attempt to recognize whether specs is reloaded.
Co-authored-by: Andy <andy@airbyte.io>
…s3-destination-spec-update
…n-spec-update' into omneshcheret/11835-s3-destination-spec-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still don't see relevant docs linked in descriptions and left a few more comments.
airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy <andy@airbyte.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion otherwise good to go!
"type": "object", | ||
"description": "Output data format", | ||
"description": "Output data format See [here](https://docs.airbyte.com/integrations/destinations/s3/#output-schema) for more details", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Output data format See [here](https://docs.airbyte.com/integrations/destinations/s3/#output-schema) for more details", | |
"description": "Format of the data output. See [here](https://docs.airbyte.com/integrations/destinations/s3/#output-schema) for more details", |
* S3 destination: updating specs regarding certification * S3 destination: updating required fields * S3 destination: updating required fields * Apply suggestions from code review Co-authored-by: Andy <andy@airbyte.io> * S3 destination: updating specs with links * S3 destination: updating specs with links * Apply suggestions from code review Co-authored-by: Andy <andy@airbyte.io> * S3 destination: added links to the fields * S3 destination: updating specs with links Co-authored-by: Andy <andy@airbyte.io>
What
We updated specs regarding certification
How
We added * or 'Optional' to fields names, reordered fields.
Recommended reading order
x.json
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.