Oracle & MongoDb destinations : Enable DAT tests #11965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aleonets/add-dat-tests-ph1
Basic - old implementation which provides backward compatibility of this PR. Advanced - comparator required for destinations with enabled DAT tests.
|
/test connector=connectors/destination-oracle
|
|
/test connector=connectors/destination-mongodb
|
…are it with actualObject elements. Expected might have empty elements and they are equal missing element in the actual Object. Also, actualObject might contain additional elements which is not an exception.
|
/test connector=connectors/destination-oracle
|
|
/test connector=connectors/destination-mongodb
|
sashaNeshcheret
approved these changes
Apr 19, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* add Boolean, Number, DateTimeWithTZ compare methods * Improve value comparison * Compare inherit objects element by element * Move comparison methods to a new class not to overload the test class. Basic - old implementation which provides backward compatibility of this PR. Advanced - comparator required for destinations with enabled DAT tests. * format * Move common method to ComparatorUtils. + Review update * format * review * review * enable DAT tests for destination-oracle * mark resolveIdentifier method as deprecated * enable DAT tests for destination-mongodb * remove size objects validation. We iterate expected elements and compare it with actualObject elements. Expected might have empty elements and they are equal missing element in the actual Object. Also, actualObject might contain additional elements which is not an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable DAT tests #9443
Recommended reading order
MongodbDestinationAcceptanceTest.javaOracleTestDataComparator.javaSshOracleDestinationAcceptanceTest.javaUnencryptedOracleDestinationAcceptanceTest.java