-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle & MongoDb destinations : Enable DAT tests #11965
Conversation
… aleonets/add-dat-tests-ph1
Basic - old implementation which provides backward compatibility of this PR. Advanced - comparator required for destinations with enabled DAT tests.
/test connector=connectors/destination-oracle
|
/test connector=connectors/destination-mongodb
|
…are it with actualObject elements. Expected might have empty elements and they are equal missing element in the actual Object. Also, actualObject might contain additional elements which is not an exception.
/test connector=connectors/destination-oracle
|
/test connector=connectors/destination-mongodb
|
* add Boolean, Number, DateTimeWithTZ compare methods * Improve value comparison * Compare inherit objects element by element * Move comparison methods to a new class not to overload the test class. Basic - old implementation which provides backward compatibility of this PR. Advanced - comparator required for destinations with enabled DAT tests. * format * Move common method to ComparatorUtils. + Review update * format * review * review * enable DAT tests for destination-oracle * mark resolveIdentifier method as deprecated * enable DAT tests for destination-mongodb * remove size objects validation. We iterate expected elements and compare it with actualObject elements. Expected might have empty elements and they are equal missing element in the actual Object. Also, actualObject might contain additional elements which is not an exception.
What
Enable DAT tests #9443
Recommended reading order
MongodbDestinationAcceptanceTest.java
OracleTestDataComparator.java
SshOracleDestinationAcceptanceTest.java
UnencryptedOracleDestinationAcceptanceTest.java