-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉Destination-bigquery-denorm: fixed emittedAt timestamp #11978
🎉Destination-bigquery-denorm: fixed emittedAt timestamp #11978
Conversation
@Override | ||
public void addAirbyteColumns(ObjectNode data, | ||
AirbyteRecordMessage recordMessage) { | ||
super.addAirbyteColumns(data, recordMessage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we created this class if overwritten method only call super implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test class is located in the test package and exposes a protected method from the main package.
@VisibleForTesting annotation doesn't work here, I didn't want to use reflection to keep code more readable.
Added a comment to code to make it more clear for those who will see this class in the future.
@Test | ||
public void testEmittedAtTimeConversion() { | ||
// in this test we don't care about json schema and naming resolver, so leave it as a null | ||
final JsonNode jsonNodeSchema = getSchema(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we consider to use mock instead of instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just forgot to remove the comment, it's not applicable for now.
Record formatted requires a valid schema for now.
But you were right, even in new code mock is also possible.
Updated, Thanks
c12cb0b
to
cb99c4c
Compare
/test connector=connectors/destination-bigquery-denormalized
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. we can proceed with merging and publishing without airbyte review
/test connector=connectors/destination-bigquery-denormalized
|
/publish connector=connectors/destination-bigquery-denormalized
|
* [11067] Destination-bigquery-denorm: fixed emittedAt timestamp
What
Currently, datetime in the emittedAt field is incorrect
How
Fixed date and checked locally, see captures below
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.