Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoMatchingConnector event #12036

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Add NoMatchingConnector event #12036

merged 2 commits into from
Apr 15, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Apr 14, 2022

What

Fixes #12033

Adds an analytics event if a user searches for a specific connector in the selectbox, but doesn't retrieve any results.

@timroes timroes requested a review from a team as a code owner April 14, 2022 18:03
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Apr 14, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did not test locally, types should catch any obvious errors.

@timroes timroes merged commit b176625 into master Apr 15, 2022
@timroes timroes deleted the tim/no-connector-analytics branch April 15, 2022 14:43
suhomud pushed a commit that referenced this pull request May 23, 2022
* Add NoMatchingConnector event

* Remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log an analytics event when no connector matching the query
2 participants