Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output normalization summary from NormalizationJobOrchestrator #12046

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Output normalization summary from NormalizationJobOrchestrator #12046

merged 1 commit into from
Apr 18, 2022

Conversation

alovew
Copy link
Contributor

@alovew alovew commented Apr 14, 2022

What

NormalizationJobOrchestrator should return NormalizationSummary

@alovew alovew force-pushed the anne/output-normalization-summary-in-orchestrator branch from 704a837 to fc143dd Compare April 14, 2022 22:13
@alovew alovew temporarily deployed to more-secrets April 14, 2022 22:15 Inactive
@alovew alovew temporarily deployed to more-secrets April 14, 2022 22:15 Inactive
@alovew alovew force-pushed the anne/output-normalization-summary-in-orchestrator branch from fc143dd to 7b1afef Compare April 15, 2022 22:56
@alovew alovew temporarily deployed to more-secrets April 15, 2022 22:58 Inactive
@alovew alovew temporarily deployed to more-secrets April 15, 2022 22:58 Inactive
@alovew alovew temporarily deployed to more-secrets April 15, 2022 23:50 Inactive
@alovew alovew temporarily deployed to more-secrets April 15, 2022 23:50 Inactive
@alovew alovew requested a review from lmossman April 16, 2022 00:01
@alovew alovew temporarily deployed to more-secrets April 16, 2022 00:14 Inactive
@alovew alovew temporarily deployed to more-secrets April 16, 2022 00:14 Inactive
@alovew alovew temporarily deployed to more-secrets April 16, 2022 00:19 Inactive
@alovew alovew temporarily deployed to more-secrets April 16, 2022 00:19 Inactive
lmossman
lmossman approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alovew alovew merged commit ea61bf6 into master Apr 18, 2022
@alovew alovew deleted the anne/output-normalization-summary-in-orchestrator branch April 18, 2022 18:08
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Apr 19, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@alovew @suhomud
Output normalization summary from NormalizationJobOrchestrator (#12046)
44420a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmossman lmossman lmossman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alovew @lmossman