Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs post-migration cleanup #12074

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

Amruta-Ranade
Copy link
Contributor

Fixing the following post-migration issues:

  • Roadmap link should go to harvestr
  • None of the docs links work on https://docs.airbyte.com/ (connector health, stepby step…).
  • Transformation and Normalization landing page doesn’t show content
  • Connector catalog page is now under Sources
  • CLI docs link is missing
  • Other misc issues

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Apr 15, 2022
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link Changes look good. The sidebar I didn't really review because the diff looks gross. I'm assuming you checked it locally.

@@ -246,8 +246,6 @@ The rest of the charts will be needing the **webinars** and `report_webinar_part

For this chart, as for the meeting’s counterpart, we will get a calculated field off the Duration field to get the **Webinar Duration in Hours**, and then plot **Created At** against the **Sum of Webinar Duration in Hours**, as shown in the screenshot below. Note: Make sure you create a new sheet for each of these graphs.

![](../../.gitbook/assets/duration-spent-in-weekly-webinars%20(3)%20(3).png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this image important here? we can probably fix this if necessary.

btw HTML standard replaces spaces like " " with "%20" which is why it says webinars%20(3) instead of webinars (3) because spaces aren't allowed in URLs/URIs (technical names for web addresses)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah I removed the image. The file is in the archive folder anyways.

@supertopher
Copy link
Contributor

image
These are good docs

@Amruta-Ranade Amruta-Ranade merged commit 68f185e into master Apr 15, 2022
@Amruta-Ranade Amruta-Ranade deleted the docs-post-migration-cleanup branch April 15, 2022 15:56
suhomud pushed a commit that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants