Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container orchestrator for cloud deploy #12076

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

alovew
Copy link
Contributor

@alovew alovew commented Apr 15, 2022

What

The container orchestrator should be deployed according to a version and/or git revision for testing cloud against different OSS versions and revisions

Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look sane. Approving based on sanity check not actual testing.

LGTM

image

@pmossman pmossman self-requested a review April 15, 2022 20:14
Copy link
Contributor

@pmossman pmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a couple tiny syntax fixes and tested that it works, you can now find dev images for the container orchestrator on dockerhub: https://hub.docker.com/repository/docker/airbyte/container-orchestrator

@alovew alovew merged commit 245e617 into master Apr 15, 2022
@alovew alovew deleted the anne/add-container-orchestrator-to-cloud-dev-deploy branch April 15, 2022 21:05
suhomud pushed a commit that referenced this pull request May 23, 2022
* Add container orchestrator for cloud deploy
Co-authored-by: Parker Mossman <parker@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants