Source Smartsheets: incremental read and tests #12077

davydov-d · 2022-04-15T17:53:42Z

What

Implement incremental read
Improve test coverage

How

Using Smartsheets SDK (as it used to be), but now Source inherits AbstractSource, not Source from airbyte_cdk. This led to a major refactoring

…crambled

davydov-d · 2022-04-15T17:55:05Z

/test connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2173733630
✅ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2173733630
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%
Name                             Stmts   Miss  Cover
----------------------------------------------------
source_smartsheets/source.py        13      0   100%
source_smartsheets/sheet.py         66      0   100%
source_smartsheets/__init__.py       2      0   100%
source_smartsheets/streams.py       37      4    89%
----------------------------------------------------
TOTAL                              118      4    97%

codecov · 2022-04-15T18:00:04Z

Codecov Report

❗ No coverage uploaded for pull request base (master@8cf4569). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12077   +/-   ##
=========================================
  Coverage          ?   96.61%           
=========================================
  Files             ?        4           
  Lines             ?      118           
  Branches          ?        0           
=========================================
  Hits              ?      114           
  Misses            ?        4           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf4569...074a1ad. Read the comment docs.

…tal-read-and-tests

davydov-d · 2022-04-18T17:50:27Z

/test connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2185198148
✅ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2185198148
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%
Name                             Stmts   Miss  Cover
----------------------------------------------------
source_smartsheets/source.py        13      0   100%
source_smartsheets/sheet.py         66      0   100%
source_smartsheets/__init__.py       2      0   100%
source_smartsheets/streams.py       37      4    89%
----------------------------------------------------
TOTAL                              118      4    97%

airbyte-integrations/connectors/source-smartsheets/source_smartsheets/spec.json

lazebnyi

LGTM

airbyte-integrations/connectors/source-smartsheets/source_smartsheets/spec.json

…tal-read-and-tests

docs/integrations/sources/smartsheets.md

davydov-d · 2022-04-27T16:56:32Z

/publish connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2234531668
🚀 Successfully published connectors/source-smartsheets
🚀 Auto-bumped version for connectors/source-smartsheets
✅ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2234531668

* #5520 fix scrambled columns bug * #5520 source smartsheets: add changelog item * #5520 move pytest to optional setup requirements * #12003 source smartsheets: implement incremental read + tests * #12003 source smartsheet: add changelog * #12003 source smartsheets: fix merge conflict on unit tests * #12003 source smartsheets: fix startdate in spec * #12003 source smartsheets: add default start dt to spec * #12003 source smartsheets: add default start dt to spec * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

davydov-d added 5 commits April 12, 2022 10:00

#5520 fix scrambled columns bug

24e25fb

#5520 source smartsheets: add changelog item

75830fe

Merge branch 'master' into ddavydov/5520-source-smartsheets-columns-s…

0f8813b

…crambled

#5520 move pytest to optional setup requirements

5a3165d

#12003 source smartsheets: implement incremental read + tests

c73aaff

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 15, 2022

#12003 source smartsheet: add changelog

b43e64c

davydov-d requested review from annalvova05 and grubberr April 15, 2022 17:55

davydov-d added 2 commits April 18, 2022 20:34

Merge branch 'master' into ddavydov/12003-source-smartsheets-incremen…

423cc89

…tal-read-and-tests

#12003 source smartsheets: fix merge conflict on unit tests

9eed5f7

grubberr reviewed Apr 19, 2022

View reviewed changes

airbyte-integrations/connectors/source-smartsheets/source_smartsheets/spec.json Outdated Show resolved Hide resolved

#12003 source smartsheets: fix startdate in spec

9c95ae8

davydov-d requested review from grubberr, lazebnyi and bazarnov April 20, 2022 09:28

grubberr approved these changes Apr 21, 2022

View reviewed changes

bazarnov approved these changes Apr 21, 2022

View reviewed changes

lazebnyi approved these changes Apr 21, 2022

View reviewed changes

airbyte-integrations/connectors/source-smartsheets/source_smartsheets/spec.json Show resolved Hide resolved

annalvova05 approved these changes Apr 21, 2022

View reviewed changes

davydov-d added 3 commits April 21, 2022 19:05

Merge branch 'master' into ddavydov/12003-source-smartsheets-incremen…

6c67e51

…tal-read-and-tests

#12003 source smartsheets: add default start dt to spec

3d60633

#12003 source smartsheets: add default start dt to spec

f82b399

davydov-d requested a review from midavadim April 26, 2022 12:49

midavadim reviewed Apr 26, 2022

View reviewed changes

docs/integrations/sources/smartsheets.md Show resolved Hide resolved

davydov-d requested a review from midavadim April 27, 2022 12:24

midavadim approved these changes Apr 27, 2022

View reviewed changes

auto-bump connector version

074a1ad

octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 17:09 Inactive

davydov-d merged commit 2eb9356 into master Apr 27, 2022

davydov-d deleted the ddavydov/12003-source-smartsheets-incremental-read-and-tests branch April 27, 2022 17:41

octavia-squidington-iii mentioned this pull request Apr 27, 2022

Bump Airbyte version from 0.36.3-alpha to 0.36.4-alpha #12415

Merged

davydov-d mentioned this pull request Apr 29, 2022

[EPIC] Source Smartsheets to Beta #11759

Closed

16 tasks

davydov-d linked an issue May 5, 2022 that may be closed by this pull request

Source Smartsheets: implement incremental read + increase tests coverage #12003

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Smartsheets: incremental read and tests #12077

Source Smartsheets: incremental read and tests #12077

davydov-d commented Apr 15, 2022

davydov-d commented Apr 15, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 15, 2022 •

edited

Loading

davydov-d commented Apr 18, 2022 •

edited by github-actions bot

Loading

lazebnyi left a comment

davydov-d commented Apr 27, 2022 •

edited by github-actions bot

Loading

Source Smartsheets: incremental read and tests #12077

Source Smartsheets: incremental read and tests #12077

Conversation

davydov-d commented Apr 15, 2022

What

How

davydov-d commented Apr 15, 2022 • edited by github-actions bot Loading

codecov bot commented Apr 15, 2022 • edited Loading

Codecov Report

davydov-d commented Apr 18, 2022 • edited by github-actions bot Loading

lazebnyi left a comment

Choose a reason for hiding this comment

davydov-d commented Apr 27, 2022 • edited by github-actions bot Loading

davydov-d commented Apr 15, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 15, 2022 •

edited

Loading

davydov-d commented Apr 18, 2022 •

edited by github-actions bot

Loading

davydov-d commented Apr 27, 2022 •

edited by github-actions bot

Loading