-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Smartsheets: incremental read and tests #12077
Source Smartsheets: incremental read and tests #12077
Conversation
/test connector=connectors/source-smartsheets
|
Codecov Report
@@ Coverage Diff @@
## master #12077 +/- ##
=========================================
Coverage ? 96.61%
=========================================
Files ? 4
Lines ? 118
Branches ? 0
=========================================
Hits ? 114
Misses ? 4
Partials ? 0 Continue to review full report at Codecov.
|
/test connector=connectors/source-smartsheets
|
airbyte-integrations/connectors/source-smartsheets/source_smartsheets/spec.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
airbyte-integrations/connectors/source-smartsheets/source_smartsheets/spec.json
Show resolved
Hide resolved
/publish connector=connectors/source-smartsheets
|
* #5520 fix scrambled columns bug * #5520 source smartsheets: add changelog item * #5520 move pytest to optional setup requirements * #12003 source smartsheets: implement incremental read + tests * #12003 source smartsheet: add changelog * #12003 source smartsheets: fix merge conflict on unit tests * #12003 source smartsheets: fix startdate in spec * #12003 source smartsheets: add default start dt to spec * #12003 source smartsheets: add default start dt to spec * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
How
Using Smartsheets SDK (as it used to be), but now Source inherits
AbstractSource
, notSource
fromairbyte_cdk
. This led to a major refactoring