Bump Google Ads version and run format #12087

marcosmarxm · 2022-04-15T21:05:23Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

working locally missing fields in click view and keyqord_view add date to campaigns add fields to click_view test

… into marcos/test-pr-9310

marcosmarxm · 2022-04-15T21:05:35Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2174402021
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2174402021
🐛 https://gradle.com/s/y3o4l2kxwhgyq
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 20 passed, 1 skipped in 1784.93s (0:29:44) =============

marcosmarxm · 2022-04-15T22:16:43Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2174629075
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2174629075
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 136     26    81%
source_google_ads/source.py                   80     27    66%
source_google_ads/custom_query_stream.py      75     50    33%
--------------------------------------------------------------
TOTAL                                        361    113    69%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/source.py                   80      4    95%
source_google_ads/streams.py                 136     10    93%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               68      7    90%
--------------------------------------------------------------
TOTAL                                        361     27    93%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 232.50s (0:03:52) ===================

marcosmarxm · 2022-04-18T16:25:09Z

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2184847501
❌ Failed to publish connectors/source-google-ads
❌ Couldn't auto-bump version for connectors/source-google-ads

marcosmarxm · 2022-04-18T22:58:30Z

/publish connector=connectors/source-google-ads auto-bump-version=false

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2186501368
🚀 Successfully published connectors/source-google-ads
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2186501368

sherifnada · 2022-04-19T06:32:42Z

airbyte-integrations/connectors/source-google-ads/integration_tests/test_incremental.py

@@ -78,17 +78,18 @@ def test_incremental_sync(config):
        if record and record.type == Type.RECORD:
            assert record.record.data["segments.date"] >= current_state

-    # Abnormal state


@marcosmarxm why did this PR remove test cases?

* combine all working locally missing fields in click view and keyqord_view add date to campaigns add fields to click_view test * configured_catalog campaigns * rem keywordview * conflicts * string type * remove network type * change ad group id to integer * fix tests * bump connector version * bump connector config doc vesion * run format Co-authored-by: Konrad <konrad@PB-Mac8.local> Co-authored-by: schlattk <konrad@pensionbee.com>

Konrad and others added 14 commits January 5, 2022 12:16

combine all

0ee1ad1

working locally missing fields in click view and keyqord_view add date to campaigns add fields to click_view test

merge master

fe5e4ba

configured_catalog campaigns

5a0808f

resolve merge conflicts

eeabecf

rem keywordview

75bed83

merge master

5494b20

conflicts

3f5c981

string type

ea95e02

remove network type

f5ce674

change ad group id to integer

9702a94

Merge branch 'google-ads-add-fields' of github.com:PensionBee/airbyte…

c227e1f

… into marcos/test-pr-9310

Merge branch 'master' into marcos/test-pr-9310

cef4c4a

Merge branch 'master' into marcos/test-pr-9310

b2cb15c

fix tests

4744832

github-actions bot added the area/connectors Connector related issues label Apr 15, 2022

bump connector version

92fffd9

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 18, 2022

bump connector config doc vesion

d42fb5e

marcosmarxm temporarily deployed to more-secrets April 18, 2022 23:00 Inactive

marcosmarxm added 2 commits April 18, 2022 21:06

Merge branch 'master' into marcos/test-pr-9310

909389b

run format

225488c

marcosmarxm changed the title ~~Publish PR 9310: new fields in google ads connector~~ Bump Google Ads version and run format Apr 19, 2022

marcosmarxm merged commit 3113ef4 into master Apr 19, 2022

marcosmarxm deleted the marcos/test-pr-9310 branch April 19, 2022 00:15

marcosmarxm temporarily deployed to more-secrets April 19, 2022 00:16 Inactive

sherifnada reviewed Apr 19, 2022

View reviewed changes

octavia-squidington-iii mentioned this pull request Apr 19, 2022

Bump Airbyte version from 0.36.0-alpha to 0.36.1-alpha #12148

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Google Ads version and run format #12087

Bump Google Ads version and run format #12087

marcosmarxm commented Apr 15, 2022

marcosmarxm commented Apr 15, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 15, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 18, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 18, 2022 •

edited by github-actions bot

Loading

sherifnada Apr 19, 2022

Bump Google Ads version and run format #12087

Bump Google Ads version and run format #12087

Conversation

marcosmarxm commented Apr 15, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Apr 15, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 15, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 18, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 18, 2022 • edited by github-actions bot Loading

sherifnada Apr 19, 2022

Choose a reason for hiding this comment

marcosmarxm commented Apr 15, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 15, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 18, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 18, 2022 •

edited by github-actions bot

Loading