-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 CDK: support loading spec from yaml file #12104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, functionality looks spot on, just some minor comments about raising correct Exceptions.
New unit tests are also great! Requesting the refactor into TestAirbyteSpec
, as per my comments, for approval 👍
@pedroslopez I'm assuming you're going to implement an example spec.yaml and update docs to explain yaml specs in another PR? |
Yep! I tried it out locally by using editable pip dependencies ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
/publish-cdk dry-run=false
|
* support loading spec from yaml file * formatting * remove commented code * update comment * remove unused file * raise correct exception types * bump version, update changelog
What
Solves #11888 by adding support for loading the connector spec from a
spec.yaml
file in addition to the existingspec.json
.How
spec.yaml
and use that if present. Existing support for json files remains unchanged.spec.yaml
andspec.json
exist, an exception will be raised.spec
method.Tests
Unit
391 passed, 537 warnings in 4.14s