Remove background/shadow from connector icon #12142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
approved these changes
Apr 19, 2022
|
|
||
| import { getIcon } from "utils/imageUtils"; | ||
|
|
||
| type Props = { |
There was a problem hiding this comment.
Suggested change
| type Props = { | |
| interface Props { |
I found that there's an advantage of using interface over type for Props because with vscode codelens you are able to see references to each individual field.
There was a problem hiding this comment.
Indeed, sorry that was a copy and paste error from copying that code from ImageBlock over :)
This was referenced Apr 20, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* Remove background/shadow from connector icon * Convert type to interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes the shadow and background color from the connector icon as discussed with Nico. This will also pull out the
ConnectorIconinto its own (clearly named) component, separating it away from theImageBlockcomponent that also could render numbers inside those circle.Using the
ConnectorIconcomponent now in all places a connector icon is shown, e.g.