-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update some connectors to use YAML specs #12230
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1ea0369
salesforce uses spec.yaml
pedroslopez 73e8efb
stripe uses spec.yaml
pedroslopez a350121
revert unintended changes
pedroslopez d7b3bd7
bump stripe version
pedroslopez 87e8609
add yaml files to package_data
pedroslopez f2cf0e6
hubspot uses a spec.yaml
pedroslopez 8f30a4e
use double quotes in yaml files
pedroslopez dd29c09
google sheets uses spec.yaml
pedroslopez ff1d757
exhcange-rates uses spec.yaml
pedroslopez 741234b
remove usage of default and enum in spec
pedroslopez 110e704
bump hubspot cdk requirement
pedroslopez 9e8a945
auto-bump connector version
octavia-squidington-iii e579adf
auto-bump connector version
octavia-squidington-iii 16bc799
manually bump versions
pedroslopez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
airbyte-integrations/connectors/source-exchange-rates/source_exchange_rates/spec.json
This file was deleted.
Oops, something went wrong.
37 changes: 37 additions & 0 deletions
37
airbyte-integrations/connectors/source-exchange-rates/source_exchange_rates/spec.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi | ||
connectionSpecification: | ||
$schema: http://json-schema.org/draft-07/schema# | ||
title: exchangeratesapi.io Source Spec | ||
type: object | ||
required: | ||
- start_date | ||
- access_key | ||
additionalProperties: false | ||
properties: | ||
start_date: | ||
type: string | ||
description: Start getting data from that date. | ||
pattern: ^[0-9]{4}-[0-9]{2}-[0-9]{2}$ | ||
examples: | ||
- YYYY-MM-DD | ||
access_key: | ||
type: string | ||
description: >- | ||
Your API Access Key. See <a | ||
href="https://exchangeratesapi.io/documentation/">here</a>. The key is | ||
case sensitive. | ||
airbyte_secret: true | ||
base: | ||
type: string | ||
description: >- | ||
ISO reference currency. See <a | ||
href="https://www.ecb.europa.eu/stats/policy_and_exchange_rates/euro_reference_exchange_rates/html/index.en.html">here</a>. | ||
Free plan doesn't support Source Currency Switching, default base | ||
currency is EUR | ||
examples: | ||
- EUR | ||
- USD | ||
ignore_weekends: | ||
type: boolean | ||
description: Ignore weekends? (Exchanges don't run on weekends) | ||
default: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 0 additions & 89 deletions
89
airbyte-integrations/connectors/source-google-sheets/google_sheets_source/spec.json
This file was deleted.
Oops, something went wrong.
83 changes: 83 additions & 0 deletions
83
airbyte-integrations/connectors/source-google-sheets/google_sheets_source/spec.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
documentationUrl: https://docs.airbyte.io/integrations/sources/google-sheets | ||
connectionSpecification: | ||
$schema: http://json-schema.org/draft-07/schema# | ||
title: Stripe Source Spec | ||
type: object | ||
required: | ||
- spreadsheet_id | ||
- credentials | ||
additionalProperties: true | ||
properties: | ||
spreadsheet_id: | ||
type: string | ||
title: Spreadsheet Link | ||
description: >- | ||
The link to your spreadsheet. See <a | ||
href='https://docs.airbyte.com/integrations/sources/google-sheets#sheetlink'>this | ||
guide</a> for more details. | ||
examples: | ||
- https://docs.google.com/spreadsheets/d/1hLd9Qqti3UyLXZB2aFfUWDT7BG-arw2xy4HR3D-dwUb/edit | ||
credentials: | ||
type: object | ||
title: Authentication | ||
description: >- | ||
Google API Credentials for connecting to Google Sheets and Google Drive | ||
APIs | ||
oneOf: | ||
- title: Authenticate via Google (OAuth) | ||
type: object | ||
required: | ||
- auth_type | ||
- client_id | ||
- client_secret | ||
- refresh_token | ||
properties: | ||
auth_type: | ||
type: string | ||
const: Client | ||
client_id: | ||
title: Client ID | ||
type: string | ||
description: The Client ID of your Google Sheets developer application. | ||
airbyte_secret: true | ||
client_secret: | ||
title: Client Secret | ||
type: string | ||
description: The Client Secret of your Google Sheets developer application. | ||
airbyte_secret: true | ||
refresh_token: | ||
title: Refresh Token | ||
type: string | ||
description: The token for obtaining new access token. | ||
airbyte_secret: true | ||
- title: Service Account Key Authentication | ||
type: object | ||
required: | ||
- auth_type | ||
- service_account_info | ||
properties: | ||
auth_type: | ||
type: string | ||
const: Service | ||
service_account_info: | ||
type: string | ||
title: Service Account Information. | ||
description: >- | ||
The JSON key of the service account to use for authorization. | ||
See <a | ||
href='https://github.com/airbytehq/airbyte/blob/master/docs/integrations/sources/google-sheets.md#setupguide'>Setup | ||
Guide</a> for more details | ||
airbyte_secret: true | ||
examples: | ||
- "{ \"type\": \"service_account\", \"project_id\": YOUR_PROJECT_ID, \"private_key_id\": YOUR_PRIVATE_KEY, ... }" | ||
authSpecification: | ||
auth_type: oauth2.0 | ||
oauth2Specification: | ||
rootObject: | ||
- credentials | ||
- 0 | ||
oauthFlowInitParameters: | ||
- ["client_id"] | ||
- ["client_secret"] | ||
oauthFlowOutputParameters: | ||
- ["refresh_token"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
airbyte-integrations/connectors/source-hubspot/acceptance-test-config.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pointing out that I noticed only hubspot has a patch version in the requirements. Others either don't have a version at all, or are set to
~=0.1