Adjust auto-disable connection logic for spam #12288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
pmossman
reviewed
Apr 26, 2022
| @@ -73,13 +75,16 @@ public AutoDisableConnectionOutput autoDisableFailingConnection(final AutoDisabl | |||
| } | |||
| } | |||
|
|
|||
| final boolean warningPreviouslySentForMaxDays = | |||
| numFailures > 1 && warningPreviouslySentForMaxDays(successTimestamp, maxDaysOfOnlyFailedJobsBeforeWarning, firstJob, jobs); | |||
There was a problem hiding this comment.
Why do we check numFailures > 1 here?
There was a problem hiding this comment.
We only send warnings/check for auto-disabling after a failure.
So if this is the first failure (numFailures == 1) then there would have been no opportunity to send a warning previously.
reading through this, makes sense to have that logic in warningPreviouslySentForMaxDays and i can just pass in numFailures
There was a problem hiding this comment.
Cool, that makes sense and yep, agreed that the logic sounds right in warningPreviouslySentForMaxDays()
pmossman
approved these changes
Apr 26, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* Adjust auto-disable connection logic for spam * refactor for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
address #12287
tldr: adds logic so if we send a warning for 50 failures in a row, we don't send another warning if there have been only failures in the past 7 days, and vice-versa.