Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update specs and definitions files for destination-postgres 0.3.19 #12317

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Update specs and definitions files for destination-postgres 0.3.19 #12317

merged 3 commits into from
Apr 27, 2022

Conversation

noahkawasaki-airbyte
Copy link
Contributor

@noahkawasaki-airbyte noahkawasaki-airbyte commented Apr 25, 2022 •
edited
Loading

What

Previously I could not publish a PR due to another inflight PR having already done a version bump but that has now merged. I have published this version and this is a PR to update the definitions and spec files to make the version usable.

Previous PR: #12195 0.3.19

How

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

@noahkawasaki-airbyte noahkawasaki-airbyte temporarily deployed to more-secrets April 25, 2022 17:42 Inactive
@noahkawasaki-airbyte noahkawasaki-airbyte temporarily deployed to more-secrets April 25, 2022 17:42 Inactive
@noahkawasaki-airbyte
Copy link
Contributor Author

noahkawasaki-airbyte commented Apr 25, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/2221876681
🚀 Successfully published connectors/destination-postgres
❌ Couldn't auto-bump version for connectors/destination-postgres

@noahkawasaki-airbyte
Copy link
Contributor Author

noahkawasaki-airbyte commented Apr 25, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-postgres auto-bump-version=false

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/2222685586
❌ Failed to publish connectors/destination-postgres

@noahkawasaki-airbyte noahkawasaki-airbyte temporarily deployed to more-secrets April 25, 2022 20:28 Inactive
@noahkawasaki-airbyte noahkawasaki-airbyte temporarily deployed to more-secrets April 25, 2022 20:28 Inactive
@noahkawasaki-airbyte noahkawasaki-airbyte changed the title Generate specs and definitions files after destination-postgres 0.3.19 Update specs and definitions files for destination-postgres 0.3.19 Apr 25, 2022
edgao
edgao approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like 0.3.19 already exists? not sure if that's expected.

also, did your changes affect destination-postgres-strict-encrypt? (if yes, you should publish it as well)

@noahkawasaki-airbyte
Copy link
Contributor Author

0.3.19 already exists yeah, I had previously published. Release workflow for this was confusing me lol.

This change would affect strict encrypt postgres destinations, I dont see any YAML entries for this destination though, should I just bump the Dockerfile for strict encrypt destination postgres?

@github-actions github-actions bot added the area/connectors Connector related issues label Apr 26, 2022
@noahkawasaki-airbyte
Copy link
Contributor Author

noahkawasaki-airbyte commented Apr 26, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-postgres-strict-encrypt

🕑 connectors/destination-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2229675409
❌ Failed to publish connectors/destination-postgres-strict-encrypt
❌ Couldn't auto-bump version for connectors/destination-postgres-strict-encrypt

@noahkawasaki-airbyte noahkawasaki-airbyte temporarily deployed to more-secrets April 26, 2022 22:19 Inactive
@noahkawasaki-airbyte noahkawasaki-airbyte temporarily deployed to more-secrets April 26, 2022 22:19 Inactive
@noahkawasaki-airbyte
Copy link
Contributor Author

noahkawasaki-airbyte commented Apr 26, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-postgres-strict-encrypt auto-bump-version=false

🕑 connectors/destination-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2229789974
❌ Failed to publish connectors/destination-postgres-strict-encrypt

@noahkawasaki-airbyte noahkawasaki-airbyte temporarily deployed to more-secrets April 26, 2022 22:49 Inactive
@noahkawasaki-airbyte noahkawasaki-airbyte temporarily deployed to more-secrets April 26, 2022 22:49 Inactive
@noahkawasaki-airbyte
Copy link
Contributor Author

noahkawasaki-airbyte commented Apr 27, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-postgres-strict-encrypt

🕑 connectors/destination-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2230276082
✅ connectors/destination-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2230276082
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       159     31    81%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           34      7    79%
normalization/transform_catalog/dbt_macro.py                                                                                       22      7    68%
normalization/transform_catalog/catalog_processor.py                                                                              147     80    46%
normalization/transform_catalog/transform.py                                                                                       61     38    38%
normalization/transform_catalog/stream_processor.py                                                                               534    345    35%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1447    550    62%

@noahkawasaki-airbyte noahkawasaki-airbyte merged commit 9f577bb into master Apr 27, 2022
@noahkawasaki-airbyte noahkawasaki-airbyte deleted the noah/publish-postgres-0.3.19 branch April 27, 2022 14:07
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Apr 27, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@noahkawasaki-airbyte @suhomud
Update specs and definitions files for destination-postgres 0.3.19 (#…
776232d 
…12317)

* Generate specs and definitions files after destination-postgres 0.3.19

* Bump destination-postgres-strict-encrypt to 0.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahkawasaki-airbyte @edgao