Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Instagram: Deleted read_insights scope from OAuth #12344

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

lazebnyi
Copy link
Collaborator

What

Slack conv: https://airbytehq.slack.com/archives/C02UF50V9HA/p1650702380620539?thread_ts=1647886872.955019&cid=C02UF50V9HA

How

Deleted read_insights from oauth scopes.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@lazebnyi lazebnyi removed the request for review from grubberr April 27, 2022 11:43
@lazebnyi lazebnyi marked this pull request as ready for review April 27, 2022 11:44
@lazebnyi lazebnyi requested a review from Phlair April 27, 2022 11:44
@Phlair
Copy link
Contributor

Phlair commented Apr 27, 2022

@lazebnyi

Slack conv: https://airbytehq.slack.com/archives/C02UF50V9HA/p1650702380620539?thread_ts=1647886872.955019&cid=C02UF50V9HA

^ this link isn't working for me. Is it in a channel I'm not in?

Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change this line in the tests because the url still has read_insights scope?

@lazebnyi lazebnyi requested a review from Phlair April 27, 2022 14:40
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lazebnyi lazebnyi merged commit eea6d1a into master Apr 27, 2022
@lazebnyi lazebnyi deleted the lazebnyi/refactor-instagram-oauth-scopes branch April 27, 2022 14:42
@lazebnyi lazebnyi temporarily deployed to more-secrets April 27, 2022 14:42 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets April 27, 2022 14:42 Inactive
suhomud pushed a commit that referenced this pull request May 23, 2022
* Deleted read_insights scope from oauth

* Deleted read_insights scope from test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants