Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source tiktok marketing: fixed specs, updated docs #12380

Merged
merged 8 commits into from
Apr 27, 2022
Merged

🎉 Source tiktok marketing: fixed specs, updated docs #12380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5396163
specs: changed order for input params, marked required params
midavadim Apr 26, 2022
79d1b7a
updated docs
midavadim Apr 26, 2022
6ac3b79
updated specs test
midavadim Apr 27, 2022
93e7639
updated connector version
midavadim Apr 27, 2022
234a5b9
auto-bump connector version
octavia-squidington-iii Apr 27, 2022
139a232
Merge remote-tracking branch 'origin/master' into midavadim/11029-tik…
midavadim Apr 27, 2022
a74b127
updated seed files
midavadim Apr 27, 2022
edde355
Merge remote-tracking branch 'origin/midavadim/11029-tiktok-specs-doc…
midavadim Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@
- name: TikTok Marketing
sourceDefinitionId: 4bfac00d-ce15-44ff-95b9-9e3c3e8fbd35
dockerRepository: airbyte/source-tiktok-marketing
dockerImageTag: 0.1.6
dockerImageTag: 0.1.7
documentationUrl: https://docs.airbyte.io/integrations/sources/tiktok-marketing
icon: tiktok.svg
sourceType: api
Expand Down
54 changes: 24 additions & 30 deletions airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8636,39 +8636,18 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-tiktok-marketing:0.1.6"
- dockerImage: "airbyte/source-tiktok-marketing:0.1.7"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/sources/tiktok-marketing"
changelogUrl: "https://docs.airbyte.io/integrations/sources/tiktok-marketing"
connectionSpecification:
title: "TikTok Marketing Source Spec"
type: "object"
properties:
start_date:
title: "Start Date"
description: "The Start Date in format: YYYY-MM-DD. Any data before this\
\ date will not be replicated. If this parameter is not set, all data\
\ will be replicated."
default: "2016-09-01"
pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2}$"
order: 0
type: "string"
report_granularity:
title: "Report Granularity"
description: "Which time granularity should be grouped by; for LIFETIME\
\ there will be no grouping. This option is used for reports' streams\
\ only."
default: "DAY"
enum:
- "LIFETIME"
- "DAY"
- "HOUR"
order: 1
type: "string"
credentials:
title: "Authorization Method"
title: "Authentication *"
default: {}
order: 3
order: 0
type: "object"
oneOf:
- title: "OAuth2.0"
Expand All @@ -8678,8 +8657,6 @@
title: "Auth Type"
const: "oauth2.0"
order: 0
enum:
- "oauth2.0"
type: "string"
app_id:
title: "App ID"
Expand Down Expand Up @@ -8707,8 +8684,6 @@
title: "Auth Type"
const: "prod_access_token"
order: 0
enum:
- "prod_access_token"
type: "string"
app_id:
title: "App ID"
Expand All @@ -8735,8 +8710,6 @@
title: "Auth Type"
const: "sandbox_access_token"
order: 0
enum:
- "sandbox_access_token"
type: "string"
advertiser_id:
title: "Advertiser ID"
Expand All @@ -8751,6 +8724,27 @@
required:
- "advertiser_id"
- "access_token"
start_date:
title: "Start Date *"
description: "The Start Date in format: YYYY-MM-DD. Any data before this\
\ date will not be replicated. If this parameter is not set, all data\
\ will be replicated."
default: "2016-09-01"
pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2}$"
order: 1
type: "string"
report_granularity:
title: "Report Granularity *"
description: "Which time granularity should be grouped by; for LIFETIME\
\ there will be no grouping. This option is used for reports' streams\
\ only."
default: "DAY"
enum:
- "LIFETIME"
- "DAY"
- "HOUR"
order: 2
type: "string"
supportsIncremental: true
supportsNormalization: false
supportsDBT: false
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-tiktok-marketing/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ COPY source_tiktok_marketing ./source_tiktok_marketing
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.6
LABEL io.airbyte.version=0.1.7
LABEL io.airbyte.name=airbyte/source-tiktok-marketing
36 changes: 18 additions & 18 deletions airbyte-integrations/connectors/source-tiktok-marketing/integration_tests/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,10 @@
"title": "TikTok Marketing Source Spec",
"type": "object",
"properties": {
"start_date": {
"title": "Start Date",
"description": "The Start Date in format: YYYY-MM-DD. Any data before this date will not be replicated. If this parameter is not set, all data will be replicated.",
"default": "2016-09-01",
"pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}$",
"order": 0,
"type": "string"
},
"report_granularity": {
"title": "Report Granularity",
"description": "Which time granularity should be grouped by; for LIFETIME there will be no grouping. This option is used for reports' streams only.",
"default": "DAY",
"enum": ["LIFETIME", "DAY", "HOUR"],
"order": 1,
"type": "string"
},
"credentials": {
"title": "Authorization Method",
"title": "Authentication *",
"default": {},
"order": 3,
"order": 0,
"type": "object",
"oneOf": [
{
Expand Down Expand Up @@ -113,6 +97,22 @@
"required": ["advertiser_id", "access_token"]
}
]
},
"start_date": {
"title": "Start Date *",
"description": "The Start Date in format: YYYY-MM-DD. Any data before this date will not be replicated. If this parameter is not set, all data will be replicated.",
"default": "2016-09-01",
"pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}$",
"order": 1,
"type": "string"
},
"report_granularity": {
"title": "Report Granularity *",
"description": "Which time granularity should be grouped by; for LIFETIME there will be no grouping. This option is used for reports' streams only.",
"default": "DAY",
"enum": ["LIFETIME", "DAY", "HOUR"],
"order": 2,
"type": "string"
}
}
},
Expand Down
16 changes: 8 additions & 8 deletions airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,26 +57,26 @@ class SourceTiktokMarketingSpec(BaseModel):
class Config:
title = "TikTok Marketing Source Spec"

credentials: Union[OauthCredSpec, ProductionEnvSpec, SandboxEnvSpec] = Field(
title="Authentication *", order=0, default={}, type="object"
)

start_date: str = Field(
title="Start Date",
title="Start Date *",
default=DEFAULT_START_DATE,
pattern="^[0-9]{4}-[0-9]{2}-[0-9]{2}$",
description="The Start Date in format: YYYY-MM-DD. Any data before this date will not be replicated. "
"If this parameter is not set, all data will be replicated.",
order=0,
order=1,
)

report_granularity: str = Field(
title="Report Granularity",
title="Report Granularity *",
description="Which time granularity should be grouped by; for LIFETIME there will be no grouping. "
"This option is used for reports' streams only.",
default=ReportGranularity.default().value,
enum=[g.value for g in ReportGranularity],
order=1,
)

credentials: Union[OauthCredSpec, ProductionEnvSpec, SandboxEnvSpec] = Field(
title="Authorization Method", order=3, default={}, type="object"
order=2,
)

@classmethod
Expand Down
Loading