Helm: Remove unused PVCs in Helm Chart

[martimors]

What

Resolves #12386

How

After feedback from @alafanechere , turns out the PVCs are completely reduntant already. This PR removes them entirely.

Recommended reading order

🤷‍♂️

🚨 User Impact 🚨

None afaik.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/SUMMARY.md
  • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub by running the /publish command described here
• After the connector is published, connector added to connector index as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

[CLAassistant]

All committers have signed the CLA.

[martimors]

I guess one question that comes to mind is whether or not this warrants a version bump of the helm chart (version in Chart.yaml)?

[alafanechere]

Yes feel free to bump, but as a patch as its not changing the default behavior of the chart. I saw from the issue that you did not succeed in deploying a working Airbyte without the PVC. Is it still the case?

[martimors]

Not the case, works fine afaict! Sorry for the confusion. I'll bump the patch.

Edit: Bumped 0.3.1->0.3.2. Included the bump in the same commit as I see that's the way it's done in other PRs.

[martimors]

Rebased the master branch on this one to resolve some merge conflicts in the helm chart README.md. Sorry about the force-pushes, figured we prefer to have a clean git history.

[alafanechere]

@dingobar, I had a chat with @davinchia . You can completely discard the PVC and it's usage in the chart. The backward compatibility is not required anymore since we remove its usage in the platform since last september.

[martimors]

Hi @alafanechere , Based on your feedback, I've re-done this PR to just removing the PVCs altogether. There are some extra changes to the README.md which were auto-generated by ci.sh update-docs, probably someone forgot to run them previously.

I've tested it locally with an S3 -> S3 job, and it works perfectly.

What do you think? Can we merge it?

Edit: Pushed again due to merge conflicts in README.md, should be good to go for another review now.

[alafanechere]

Thank you @dingobar for the modifications!
Ready to merge.