Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Analytics: always sync data from two days ago #12426

Merged
merged 8 commits into from
May 3, 2022
Merged

Source Google Analytics: always sync data from two days ago #12426

merged 8 commits into from
May 3, 2022

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Apr 28, 2022 •
edited by Phlair
Loading

Sync data from 2 days ago to make sure data is golden

#12013

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 28, 2022
@davydov-d davydov-d linked an issue Apr 28, 2022 that may be closed by this pull request
Google Analytics source: expose “isDataGolden” flag #12013
Closed
@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 28, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2237898352
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2237898352
🐛 https://gradle.com/s/hnizqrhzu6lzu
Python short test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
=================== 1 failed, 22 passed in 79.15s (0:01:19) ====================

@davydov-d davydov-d self-assigned this Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2476a79). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12426   +/-   ##
=========================================
  Coverage          ?   91.78%           
=========================================
  Files             ?        2           
  Lines             ?      280           
  Branches          ?        0           
=========================================
  Hits              ?      257           
  Misses            ?       23           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2476a79...1dec82f. Read the comment docs.

@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 28, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2238876187
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2238876187
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_google_analytics_v4/__init__.py       2      0   100%
source_google_analytics_v4/source.py       278     23    92%
------------------------------------------------------------
TOTAL                                      280     23    92%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 21 passed, 1 skipped in 36.85s ========================

@davydov-d davydov-d mentioned this pull request Apr 29, 2022
Closed
2 tasks
sherifnada
sherifnada approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, LGTM once you make the change

airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 1, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2252924451
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2252924451
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_google_analytics_v4/__init__.py       2      0   100%
source_google_analytics_v4/source.py       278     23    92%
------------------------------------------------------------
TOTAL                                      280     23    92%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 21 passed, 1 skipped in 45.63s ========================

@davydov-d davydov-d requested a review from sherifnada May 1, 2022 09:18
Phlair
Phlair approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, made one suggestion to improve clarity in the docs

docs/integrations/sources/google-analytics-v4.md Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/acceptance-test-config.yml Show resolved Hide resolved
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 3, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2263212144
🚀 Successfully published connectors/source-google-analytics-v4
🚀 Auto-bumped version for connectors/source-google-analytics-v4
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2263212144

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 3, 2022 10:27 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 3, 2022 10:27 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 3, 2022 11:09 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 3, 2022 11:09 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 3, 2022 14:22 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 3, 2022 14:22 Inactive
@davydov-d davydov-d merged commit e6ee556 into master May 3, 2022
@davydov-d davydov-d deleted the ddavydov/12013-expose-isDataGolden-field branch May 3, 2022 14:24
suhomud pushed a commit that referenced this pull request May 23, 2022
@davydov-d @octavia-squidington-iii @suhomud
Source Google Analytics: always sync data from two days ago (#12426)
43b4bb4 
* #12013 source GA to Beta: always sync data from two days ago

* #12013 GA to Beta: fix changelog

* #12013 source GA to Beta: rm odd file

* #12013 Source GA to Beta: comment out integration tests

* #12013 expose isDataGolden field, assume missing field equals False

* #12013 expose isDataGOlden flag: reword docs

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@Phlair Phlair Phlair approved these changes

@annalvova05 annalvova05 annalvova05 approved these changes

@grubberr grubberr Awaiting requested review from grubberr

@midavadim midavadim Awaiting requested review from midavadim

Assignees

@davydov-d davydov-d

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Analytics source: expose “isDataGolden” flag
5 participants
@davydov-d @sherifnada @Phlair @annalvova05 @octavia-squidington-iii