-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Google Analytics: always sync data from two days ago #12426
Conversation
/test connector=connectors/source-google-analytics-v4
|
Codecov Report
@@ Coverage Diff @@
## master #12426 +/- ##
=========================================
Coverage ? 91.78%
=========================================
Files ? 2
Lines ? 280
Branches ? 0
=========================================
Hits ? 257
Misses ? 23
Partials ? 0 Continue to review full report at Codecov.
|
/test connector=connectors/source-google-analytics-v4
|
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/acceptance-test-config.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, LGTM once you make the change
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-google-analytics-v4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, made one suggestion to improve clarity in the docs
airbyte-integrations/connectors/source-google-analytics-v4/acceptance-test-config.yml
Show resolved
Hide resolved
/publish connector=connectors/source-google-analytics-v4
|
* #12013 source GA to Beta: always sync data from two days ago * #12013 GA to Beta: fix changelog * #12013 source GA to Beta: rm odd file * #12013 Source GA to Beta: comment out integration tests * #12013 expose isDataGolden field, assume missing field equals False * #12013 expose isDataGOlden flag: reword docs * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sync data from 2 days ago to make sure data is golden
#12013