Ignore auto-disable activity if connection already inactive #12507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
pmossman
approved these changes
May 2, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* Ignore auto disable activity if already inactive * fix formatting * fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ignore the auto-disable failing connections activity if the connection is already in an
Inactivestate.Previously, a failing connection will run through the entire activity even if the connection's state is
Inactive, such as when triggered by a manual sync. This in turn may result in auto-disable or warning notifications of no use since the connection is already disabled.This PR helps reduce work and reduces irrelevant notifications to users in those previously mentioned situations.