Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Bigquery: Update Dataset location field description #12528

Merged
merged 6 commits into from
May 3, 2022
Merged

Destination Bigquery: Update Dataset location field description #12528

merged 6 commits into from
May 3, 2022

Conversation

girarda
Copy link
Contributor

@girarda girarda commented May 2, 2022 •
edited
Loading

What

  • Update dataset location field description to make it clear that the field is required and has no default value

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 2, 2022
@girarda girarda changed the title Update field description Destination Bigquery: Update Dataset location field description May 2, 2022
@girarda girarda requested a review from brianjlai May 2, 2022 22:41
@girarda
Copy link
Contributor Author

girarda commented May 2, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery

❌ Failed to publish connectors/destination-bigquery
❌ Couldn't auto-bump version for connectors/destination-bigquery

@girarda
Copy link
Contributor Author

girarda commented May 2, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery-denormalized

❌ Failed to publish connectors/destination-bigquery-denormalized
❌ Couldn't auto-bump version for connectors/destination-bigquery-denormalized

@girarda
Copy link
Contributor Author

girarda commented May 2, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery

❌ Failed to publish connectors/destination-bigquery
❌ Couldn't auto-bump version for connectors/destination-bigquery

@girarda
Copy link
Contributor Author

girarda commented May 2, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2260903844
🚀 Successfully published connectors/destination-bigquery
🚀 Auto-bumped version for connectors/destination-bigquery
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2260903844

@girarda
Copy link
Contributor Author

girarda commented May 2, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2260976288
❌ Failed to publish connectors/destination-bigquery-denormalized
❌ Couldn't auto-bump version for connectors/destination-bigquery-denormalized

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 2, 2022 23:42 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 2, 2022 23:42 Inactive
@girarda
Copy link
Contributor Author

girarda commented May 2, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2261087553
🚀 Successfully published connectors/destination-bigquery-denormalized
🚀 Auto-bumped version for connectors/destination-bigquery-denormalized
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2261087553

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 3, 2022 00:32 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 3, 2022 00:32 Inactive
@girarda girarda merged commit 1021428 into master May 3, 2022
@girarda girarda deleted the alex/bigquerydescription branch May 3, 2022 00:45
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 3, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@girarda @octavia-squidington-iii @suhomud
Destination Bigquery: Update Dataset location field description (#1…
e6170e0 
…2528)

* Update field description

* reset

* Bump

* reset

* auto-bump connector version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjlai brianjlai brianjlai approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@girarda @brianjlai @octavia-squidington-iii