Use host.docker.internal for acceptance testing on macs
#12791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmossman
approved these changes
May 11, 2022
4 tasks
|
@pmossman looks like we did need to consider this change just for "dev" users - re-review requested. |
evantahler
changed the title
host.docker.internal for acceptance testinghost.docker.internal for acceptance testing on macs
pmossman
approved these changes
May 11, 2022
|
cc @davinchia |
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* Use `host.docker.internal` for acceptance testing * Lint * conditional hostname for mac only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the acceptance test host on Macs to be
host.docker.internalrather thanlocalhost. This fixes a class of problems that prevented developers (me!) from running acceptance tests locally. This change does not effect K8s test runners.This bug may be due to a new version of Docker Desktop + M1 Macs.