Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Postgres source: fix azure database catalog retrieval #12834

Merged
merged 5 commits into from
May 13, 2022
Merged

🐞 Postgres source: fix azure database catalog retrieval #12834

merged 5 commits into from
May 13, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented May 13, 2022 •
edited
Loading

What

  • Azure Postgres server has this username pattern: <username>@<host>.
  • However, inside Postgres, the true username is <username>.
  • We need the true username to retrieve tables that are accessible to the user. Using the full username results in an empty catalog.
  • Resolve https://github.com/airbytehq/oncall/issues/225.

How

  • This PR adds a method to return the true username when checking for table permissions.

🚨 User Impact 🚨

  • Currently, users cannot sync any data using the latest Postgres source connector 0.4.14.
  • After this PR is deployed, this issue will be fixed.

@github-actions github-actions bot added the area/connectors Connector related issues label May 13, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 13, 2022
@tuliren
Copy link
Contributor Author

tuliren commented May 13, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2317831000
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2317831000
No Python unittests run

@tuliren
Copy link
Contributor Author

tuliren commented May 13, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2317831659
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2317831659
No Python unittests run

@tuliren tuliren requested a review from evantahler May 13, 2022 07:08
@tuliren
Copy link
Contributor Author

tuliren commented May 13, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres run-tests=false

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2318116191
🚀 Successfully published connectors/source-postgres
🚀 Auto-bumped version for connectors/source-postgres
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2318116191

@tuliren
Copy link
Contributor Author

tuliren commented May 13, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres-strict-encrypt run-tests=false

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2318116843
🚀 Successfully published connectors/source-postgres-strict-encrypt
❌ Couldn't auto-bump version for connectors/source-postgres-strict-encrypt

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 13, 2022 08:23 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 13, 2022 08:23 Inactive
@tuliren tuliren merged commit 7d16fda into master May 13, 2022
@tuliren tuliren deleted the liren/patch-azure-postgres branch May 13, 2022 08:35
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 13, 2022
Merged
evantahler
evantahler reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turn-around!

suhomud pushed a commit that referenced this pull request May 23, 2022
@tuliren @octavia-squidington-iii @suhomud
🐞 Postgres source: fix azure database catalog retrieval (#12834)
9907cda 
* Remove host in azure username

* Bump version

* Fix test

* Replace host with jdbc_url

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler left review comments

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliren @evantahler @octavia-squidington-iii