add java code auto reformat to build #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-tricot
approved these changes
Aug 7, 2020
build.gradle
Outdated
| @@ -33,5 +39,7 @@ subprojects { | |||
| testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.4.2' | |||
| testImplementation 'org.junit.jupiter:junit-jupiter-api:5.4.2' | |||
| testImplementation group: 'org.mockito', name: 'mockito-junit-jupiter', version: '3.4.6' | |||
|
|
|||
| compile group: "com.google.googlejavaformat", name: "google-java-format", version: "1.8" | |||
There was a problem hiding this comment.
I am surprised that it is in the code deps since it should only be needed to run the tool
There was a problem hiding this comment.
me too. i'll double check that i have done something dumb here.
sherifnada
approved these changes
Aug 7, 2020
jrhizor
approved these changes
Aug 7, 2020
|
You can install https://plugins.jetbrains.com/plugin/8527-google-java-format/ |
This was referenced Oct 28, 2022
37 tasks
c-p-b
pushed a commit
that referenced
this pull request
Feb 17, 2023
* remove connectors tools from /tools * remove deploy docs workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this first commit adds the necessary plugin and applies the build rules. i'm still pretty new to gradle so if there's a a better way to do it lmk. i was trying to push more of it into the build.gradle in the root but couldn't figure out how to do it quickly.
the second commit is with all the code auto reformat applied.