Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Amazon Ads: increase SAT test_read timeout #13073

Merged
merged 3 commits into from
May 23, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented May 21, 2022

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

increase SAT test_read timeout: 600 sec

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/connectors Connector related issues label May 21, 2022
@grubberr grubberr self-assigned this May 21, 2022
@grubberr grubberr requested review from evantahler and lazebnyi May 21, 2022 04:47
@grubberr
Copy link
Contributor Author

grubberr commented May 21, 2022

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2361962863
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2361962863
🐛 https://gradle.com/s/b5mt5bzxxu2hq

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@fa62e68). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13073   +/-   ##
=========================================
  Coverage          ?   98.79%           
=========================================
  Files             ?       22           
  Lines             ?      663           
  Branches          ?        0           
=========================================
  Hits              ?      655           
  Misses            ?        8           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa62e68...9b78a24. Read the comment docs.

@grubberr
Copy link
Contributor Author

grubberr commented May 21, 2022

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2362037057
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2362037057
🐛 https://gradle.com/s/2ejlwnsahjgfu
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 24 passed, 1 skipped in 1294.85s (0:21:34) =============

@grubberr
Copy link
Contributor Author

grubberr commented May 22, 2022

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2365278606
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2365278606
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            28      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               663      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 25 passed, 1 skipped in 745.08s (0:12:25) ===================

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shame, but a reasonable change!

@grubberr grubberr merged commit 2b90559 into master May 23, 2022
@grubberr grubberr deleted the grubberr/source-amazon-ads-sat-timeout-increase branch May 23, 2022 04:14
suhomud pushed a commit that referenced this pull request May 23, 2022
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@lazebnyi lazebnyi removed their request for review May 30, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants