Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harshith/test pr 12806 #13082

Merged
merged 5 commits into from
May 23, 2022
Merged

Harshith/test pr 12806 #13082

merged 5 commits into from
May 23, 2022

Conversation

harshithmullapudi
Copy link
Contributor

What

closes #12806

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 23, 2022

/test connector=source-pipedrive

🕑 source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2370622623
✅ source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2370622623
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pipedrive/__init__.py       2      0   100%
source_pipedrive/source.py        36      2    94%
source_pipedrive/streams.py       77      8    90%
--------------------------------------------------
TOTAL                            115     10    91%

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 23, 2022
@harshithmullapudi
Copy link
Contributor Author

Opened this as the permission to push to the remote repo has been restricted

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 23, 2022 10:28 Inactive
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@2b90559). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13082   +/-   ##
=========================================
  Coverage          ?   91.30%           
=========================================
  Files             ?        3           
  Lines             ?      115           
  Branches          ?        0           
=========================================
  Hits              ?      105           
  Misses            ?       10           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b90559...0503920. Read the comment docs.

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 23, 2022

/publish connector=connectors/source-pipedrive auto-bump-version=false

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2370671924
🚀 Successfully published connectors/source-pipedrive
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2370671924

@marcNY
Copy link

marcNY commented Jan 13, 2023

With this change the Incremental Models do not work anymore. #21377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants