-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Mixpanel: Beta preparation #13372
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #13372 +/- ##
=========================================
Coverage ? 90.49%
=========================================
Files ? 13
Lines ? 421
Branches ? 0
=========================================
Hits ? 381
Misses ? 40
Partials ? 0 Continue to review full report at Codecov.
|
- Update doc
/test connector=source-mixpanel
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/base.py
Show resolved
Hide resolved
@bazarnov This PR is breaking production builds because it has not been published stack trace
I honestly don't really understand the workflow or what publishing is exactly in this use case. Can you help me understand the best way to get prod back in fighting shape quickly? |
What
How
streams
, that checkis_testing
flag in config, and reduces amount of requests that is made in acceptance testsdate_window_size
to spec, so client will be able to iterate through data via smaller batchesSort property names, and check for such cases, and transform
userName
->_userName
If such collission occurs more than one time, then
will be transformed to
Recommended reading order
Huge line change number is caused only by moving streams into distinct module
source.py
is added decorator tostreams
methodExport
(streams/export.py) source, where properties are transformed viatransform_property_names
Pre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here